public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Leonid Isaev <lisaev@umail.iu.edu>
To: Borislav Petkov <bp@alien8.de>
Cc: "Matthew Garrett" <matthew.garrett@nebula.com>,
	"André Przywara" <andre@andrep.de>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, "Tom Gundersen" <teg@jklm.no>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [arch-general] powernow-k8 fails to load with linux 3.7.2
Date: Sun, 20 Jan 2013 23:14:32 -0600	[thread overview]
Message-ID: <20130120231432.67351ee6@bluemoon> (raw)
In-Reply-To: <20130119120814.GA4026@pd.tnic>

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

On Sat, 19 Jan 2013 13:08:14 +0100
Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Jan 18, 2013 at 03:17:04PM +0000, Matthew Garrett wrote:
> > Can you try this (entirely untested) patch?
> > 
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c
> > b/drivers/cpufreq/acpi-cpufreq.c
> > index 0d048f6..7b0d49d 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -1030,4 +1030,11 @@ MODULE_PARM_DESC(acpi_pstate_strict,
> >  late_initcall(acpi_cpufreq_init);
> >  module_exit(acpi_cpufreq_exit);
> >  
> > +static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> > +	X86_FEATURE_MATCH(X86_FEATURE_ACPI),
> > +	X86_FEATURE_MATCH(X86_FEATURE_HW_PSTATE),
> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids);
> > +
> >  MODULE_ALIAS("acpi");
> 
> Leonid, can you try Matthew's patch?
> 
> This is adding the additional cpufreatures aliases:
> 
> alias:          x86cpu:vendor:*:family:*:model:*:feature:*00E8*
> alias:          x86cpu:vendor:*:family:*:model:*:feature:*0016*
> 
> and since powernow-k8 used to load on 3.6-stable, it probably happened
> because the 0xe8 feature and since 3.7 moved it to acpi-cpufreq, this
> patch should actually fix it.
> 
> Thanks.
> 

Matthew and Borislav, thanks a lot for the patch and explanation!

I applied the above patch on top of linux 3.7.3 -- it does generate the
aliases and fixes the autoprobing issue, at least on my AMD machine. Should we
expect it in 3.7.4 or 3.8? Otherwise, I'll forward it to archlinux devel ML to
be possibly included in current -stable kernel. Also, Borislav, this patch is
not in your patch series, is it?

Thanks again,
L.

-- 
Leonid Isaev
GnuPG key: 0x164B5A6D
Fingerprint: C0DF 20D0 C075 C3F1 E1BE  775A A7AE F6CB 164B 5A6D

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2013-01-21  5:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130115224755.085aa6b7@bluemoon>
     [not found] ` <CAG-2HqWPOYKVCj-Z=z_1e=mE6b6z9hMYFJzHf2GYAmTwQovN0A@mail.gmail.com>
     [not found]   ` <20130116131725.4e590c34@bluemoon>
2013-01-16 20:37     ` [arch-general] powernow-k8 fails to load with linux 3.7.2 Tom Gundersen
2013-01-16 22:33       ` Rafael J. Wysocki
2013-01-16 23:17         ` Borislav Petkov
     [not found]           ` <20130116181600.4c48ee3b@bluemoon>
2013-01-17  9:46             ` Borislav Petkov
2013-01-17 10:34               ` Tom Gundersen
2013-01-18  1:27                 ` Leonid Isaev
2013-01-18  1:40               ` Leonid Isaev
2013-01-18 11:37                 ` Borislav Petkov
2013-01-18 12:32                   ` André Przywara
2013-01-18 15:17                     ` Matthew Garrett
2013-01-18 15:26                       ` Borislav Petkov
2013-01-18 15:32                         ` Matthew Garrett
2013-01-18 17:10                           ` Borislav Petkov
2013-01-18 17:17                             ` Matthew Garrett
2013-01-19 12:08                       ` Borislav Petkov
2013-01-21  5:14                         ` Leonid Isaev [this message]
2013-01-21 10:54                           ` Borislav Petkov
2013-01-18 17:13                     ` Leonid Isaev
2013-01-18 16:59                   ` Leonid Isaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130120231432.67351ee6@bluemoon \
    --to=lisaev@umail.iu.edu \
    --cc=andre@andrep.de \
    --cc=bp@alien8.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=rjw@sisk.pl \
    --cc=teg@jklm.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox