From: Borislav Petkov <bp@alien8.de>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: rjw@sisk.pl, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
Leonid Isaev <lisaev@umail.iu.edu>
Subject: Re: [PATCH] Add module aliases for acpi-cpufreq
Date: Tue, 22 Jan 2013 18:38:36 +0100 [thread overview]
Message-ID: <20130122173835.GB6431@pd.tnic> (raw)
In-Reply-To: <1358872944-7676-1-git-send-email-matthew.garrett@nebula.com>
On Tue, Jan 22, 2013 at 11:42:24AM -0500, Matthew Garrett wrote:
> The acpi core will call request_module("acpi-cpufreq") on subsystem init,
> but this will fail if the module isn't available at that stage of boot.
> Add some module aliases to ensure that udev can load the module on Intel
> and AMD systems with the appropriate feature bits - I /think/ that this
> will also work on VIA systems, but haven't verified that.
>
> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Let's add some more tags:
Link: http://lkml.kernel.org/r/1448223.sdUJnNSRz4@vostro.rjw.lan
Tested-by: Leonid Isaev <lisaev@umail.iu.edu>
Acked-by: Borislav Petkov <bp@suse.de>
Rafael, this is all yours. :-)
Thanks.
> ---
> drivers/cpufreq/acpi-cpufreq.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 0d048f6..7b0d49d 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1030,4 +1030,11 @@ MODULE_PARM_DESC(acpi_pstate_strict,
> late_initcall(acpi_cpufreq_init);
> module_exit(acpi_cpufreq_exit);
>
> +static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> + X86_FEATURE_MATCH(X86_FEATURE_ACPI),
> + X86_FEATURE_MATCH(X86_FEATURE_HW_PSTATE),
> + {}
> +};
> +MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids);
> +
> MODULE_ALIAS("acpi");
> --
> 1.8.0.2
>
>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-01-22 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 16:42 [PATCH] Add module aliases for acpi-cpufreq Matthew Garrett
2013-01-22 17:38 ` Borislav Petkov [this message]
2013-01-22 21:57 ` Rafael J. Wysocki
2013-01-22 22:05 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130122173835.GB6431@pd.tnic \
--to=bp@alien8.de \
--cc=cpufreq@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisaev@umail.iu.edu \
--cc=matthew.garrett@nebula.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).