From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [patch] sysfs: Fix build when sysfs is disabled Date: Fri, 25 Jan 2013 12:42:34 -0800 Message-ID: <20130125204234.GA13245@kroah.com> References: <3307415.pdOY6ovZLa@vostro.rjw.lan> <2760421.6nE3tkh92K@vostro.rjw.lan> <1551140.kO91IOVbjI@vostro.rjw.lan> <1511541.AH8DLsNQJH@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f45.google.com ([209.85.210.45]:38877 "EHLO mail-da0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372Ab3AYUmh (ORCPT ); Fri, 25 Jan 2013 15:42:37 -0500 Received: by mail-da0-f45.google.com with SMTP id w4so336992dam.4 for ; Fri, 25 Jan 2013 12:42:36 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: David Rientjes Cc: "Rafael J. Wysocki" , "Kristen C. Accardi" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jan 25, 2013 at 12:13:59PM -0800, David Rientjes wrote: > "sysfs: Functions for adding/removing symlinks to/from attribute groups" > causes a build failure when CONFIG_SYSFS is disabled: > > drivers/acpi/power.c: In function 'acpi_power_hide_list': > drivers/acpi/power.c:463: error: implicit declaration of function 'sysfs_remove_link_from_group' > drivers/acpi/power.c: In function 'acpi_power_expose_list': > drivers/acpi/power.c:486: error: implicit declaration of function 'sysfs_add_link_to_group' > > We need to define empty functions for this config to avoid ifdefs in the > code. > > Signed-off-by: David Rientjes > --- > include/linux/sysfs.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Acked-by: Greg Kroah-Hartman Rafael has to take this through his tree.