From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Zheng, Lv" <lv.zheng@intel.com>
Cc: Alan Cox <alan@linux.intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Brown, Len" <len.brown@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"Jiri Slaby (jslaby@suse.cz)" <jslaby@suse.cz>,
"Heikki Krogerus (heikki.krogerus@linux.intel.com)"
<heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v5 1/2] TTY: Add TTY slave enumeration support
Date: Tue, 29 Jan 2013 23:46:03 -0500 [thread overview]
Message-ID: <20130130044603.GC30002@kroah.com> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E88BF46D2@SHSMSX101.ccr.corp.intel.com>
On Mon, Jan 28, 2013 at 02:58:00AM +0000, Zheng, Lv wrote:
> Which one do you think is better? V2 or V5 (I have completed the test
> and now I have the V6 ones, I can send them out if you think the
> tty_enum bus is better than the serial_bus).
I don't know, if you have a patch set you want to have reviewed, please
send it, I don't have the time to dig through the links you sent me to
old patch versions, nor should you ever expect someone to do that.
But whatever you send, it better not contain a duplicate of the existing
tty class code, like your last patchset did, that's not going to be
acceptable at all for the reasons I said.
Again, take advantage of your Intel internal Linux kernel developers for
the proper review of your code, and test it! Your last patch set
showed that this obviously did not happen, and I'm not going to look at
anything further from you until you get a signed-off-by by at least one
of them first (preferably more than one.)
greg k-h
next prev parent reply other threads:[~2013-01-30 4:46 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 3:39 [RFC PATCH 0/3] ACPI/UART: Add ACPI 5.0 enueration support for UART Lv Zheng
2012-12-03 3:39 ` [RFC PATCH 1/3] UART: Add UART subsystem as a bus Lv Zheng
2012-12-03 11:46 ` Alan Cox
2012-12-05 3:37 ` Zheng, Lv
2012-12-04 18:54 ` Mika Westerberg
2012-12-04 19:50 ` Alan Cox
2012-12-05 6:20 ` Mika Westerberg
2012-12-05 7:07 ` Zheng, Lv
2012-12-05 7:42 ` Mika Westerberg
2012-12-05 9:43 ` Alan Cox
2012-12-06 1:26 ` Zheng, Lv
2012-12-06 1:55 ` Zheng, Lv
2012-12-06 13:53 ` Alan Cox
2012-12-07 4:54 ` Zheng, Lv
2012-12-07 5:41 ` Zheng, Lv
2012-12-07 7:24 ` Huang Ying
2012-12-07 10:27 ` Alan Cox
2012-12-07 10:25 ` Alan Cox
2012-12-06 7:36 ` Zheng, Lv
2012-12-06 7:52 ` Mika Westerberg
2012-12-05 3:49 ` Zheng, Lv
2012-12-03 3:40 ` [RFC PATCH 2/3] ACPI / UART: Add ACPI enumeration support for UART bus Lv Zheng
2012-12-03 3:40 ` [RFC PATCH 3/3] UART: Add dummy devices to test the enumeration Lv Zheng
2012-12-05 3:51 ` [PATCH v2 0/4] ACPI/UART: Add ACPI 5.0 enueration support for UART Lv Zheng
2012-12-05 3:51 ` [PATCH v2 1/4] UART: Add UART subsystem as a bus Lv Zheng
2012-12-05 3:51 ` [PATCH v2 2/4] ACPI / UART: Add ACPI enumeration support for UART bus Lv Zheng
2012-12-05 3:51 ` [PATCH v2 3/4] UART / 8250: Add declearation of serial8250 driver Lv Zheng
2012-12-05 3:52 ` [PATCH v2 4/4] UART: Add dummy devices to test the enumeration Lv Zheng
2012-12-06 9:21 ` [RFC PATCH v3 0/4] ACPI/UART: Add ACPI 5.0 enueration support for UART Lv Zheng
2012-12-06 9:21 ` [RFC PATCH v3 1/4] UART: Add UART subsystem as a bus Lv Zheng
2012-12-06 13:40 ` Alan Cox
2012-12-07 3:52 ` Zheng, Lv
2012-12-07 10:22 ` Alan Cox
2012-12-06 9:22 ` [RFC PATCH v3 2/4] ACPI / UART: Add ACPI enumeration support for UART bus Lv Zheng
2012-12-06 9:22 ` [RFC PATCH v3 3/4] UART / 8250: Add declearation of serial8250 driver Lv Zheng
2012-12-06 9:22 ` [RFC PATCH v3 4/4] UART: Add dummy devices to test the enumeration Lv Zheng
2013-01-09 9:17 ` [RFC PATCH v4 0/3] ACPI/UART: Add ACPI 5.0 enueration support for UART Lv Zheng
2013-01-09 9:17 ` [RFC PATCH v4 1/3] TTY: Add TTY slave enumeration support Lv Zheng
2013-01-09 9:17 ` Lv Zheng
2013-01-09 9:18 ` [RFC PATCH v4 2/3] ACPI / UART: Add ACPI enumeration support for UART Lv Zheng
2013-01-09 9:18 ` Lv Zheng
2013-01-09 9:18 ` [RFC PATCH v4 3/3] UART: Add dummy devices to test the enumeration Lv Zheng
2013-01-09 9:18 ` Lv Zheng
2013-01-09 9:17 ` [RFC PATCH v4 0/3] ACPI/UART: Add ACPI 5.0 enueration support for UART Lv Zheng
2013-01-24 10:30 ` [PATCH v5 0/2] ACPI/UART: Add ACPI 5.0 enumeration " Lv Zheng
2013-01-24 10:30 ` [PATCH v5 1/2] TTY: Add TTY slave enumeration support Lv Zheng
2013-01-25 21:41 ` Greg Kroah-Hartman
2013-01-26 0:32 ` Alan Cox
2013-01-26 0:21 ` Greg Kroah-Hartman
2013-01-26 3:04 ` Zheng, Lv
2013-01-26 3:42 ` Greg Kroah-Hartman
2013-01-28 2:58 ` Zheng, Lv
2013-01-30 4:46 ` Greg Kroah-Hartman [this message]
2013-01-25 21:45 ` Greg Kroah-Hartman
2013-01-26 3:12 ` Zheng, Lv
2013-01-26 3:44 ` Greg Kroah-Hartman
2013-01-28 3:02 ` Zheng, Lv
2013-01-24 10:30 ` [PATCH v5 2/2] ACPI / UART: Add ACPI enumeration support for UART Lv Zheng
2013-01-24 10:30 ` [RFC PATCH v5] HACK: UART: Add dummy devices to test the enumeration Lv Zheng
2013-02-06 6:26 ` [RFC PATCH] ACPI / serial: Add UART change_pm support with ACPI power domain Lv Zheng
2013-02-06 19:07 ` Greg Kroah-Hartman
2013-02-06 21:39 ` Rafael J. Wysocki
2013-02-06 21:38 ` Greg Kroah-Hartman
2013-02-07 0:38 ` Zheng, Lv
2013-04-03 2:05 ` [PATCH v6] ACPI / serial: Add peripheral PnP IDs enumeration support Lv Zheng
2013-04-03 16:14 ` Greg Kroah-Hartman
2013-04-04 10:12 ` Zheng, Lv
2013-04-07 3:05 ` Zheng, Lv
2013-04-04 15:43 ` Zheng, Lv
2013-04-04 18:23 ` Greg Kroah-Hartman
2013-04-07 3:11 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130044603.GC30002@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).