From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mandeep Singh Baines <msb@chromium.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
ibm-acpi@hmh.eng.br, ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Aaron Lu <aaron.lu@intel.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
Tejun Heo <tj@kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Artem Savkov <artem.savkov@gmail.com>
Subject: Re: [PATCH] thinkpad-acpi: fix potential suspend blocking issue
Date: Wed, 6 Mar 2013 16:50:39 +0100 [thread overview]
Message-ID: <20130306155039.GB7697@redhat.com> (raw)
In-Reply-To: <20130305141817.4e27e83aa66598115e52eb9e@linux-foundation.org>
On 03/05, Andrew Morton wrote:
>
> Basically the same as
> http://ozlabs.org/~akpm/mmots/broken-out/drivers-platform-x86-thinkpad_acpic-move-hotkey_thread_mutex-lock-after-set_freezable.patch.
> I think Artem's patch is a little better. There doesn't appear to be
> any locking protocol for tpacpi_lifecycle.
Which seems to have the same problem, hotkey_kthread() still calls
kthread_freezable_should_stop() under hotkey_thread_mutex.
IOW, we have two try_to_freeze's here, the patch moves only one of
them outside of the hotkey_thread_mutex.
Oleg.
next prev parent reply other threads:[~2013-03-06 15:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 19:55 [REGRESSION] [3.9-rc1] BUG: ktpacpi_nvramd/446 still has locks held! Maciej Rutecki
2013-03-05 7:28 ` Aaron Lu
2013-03-05 16:04 ` Mandeep Singh Baines
2013-03-05 17:34 ` [PATCH] thinkpad-acpi: fix potential suspend blocking issue Mandeep Singh Baines
2013-03-05 17:48 ` Oleg Nesterov
2013-03-05 17:59 ` Mandeep Singh Baines
2013-03-05 18:05 ` Oleg Nesterov
2013-03-05 20:55 ` Mandeep Singh Baines
2013-03-05 23:26 ` Henrique de Moraes Holschuh
2013-03-06 15:44 ` Oleg Nesterov
2013-03-06 23:32 ` Henrique de Moraes Holschuh
[not found] ` <20130306233232.GA12645-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2013-03-07 17:53 ` [PATCH 0/1] thinkpad-acpi: kill hotkey_thread_mutex Oleg Nesterov
2013-03-07 17:53 ` [PATCH 1/1] " Oleg Nesterov
2013-03-07 18:42 ` Mandeep Singh Baines
[not found] ` <CACBanvqP0jx_d-LtV5+fRD7M698M_b6j0Sv=v0uoTBpjEusQCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-09 21:34 ` Henrique de Moraes Holschuh
2013-03-26 13:14 ` Rafael J. Wysocki
2013-03-26 13:09 ` Oleg Nesterov
2013-03-26 13:50 ` Rafael J. Wysocki
2013-03-05 19:18 ` [PATCH] thinkpad-acpi: fix potential suspend blocking issue Maciej Rutecki
2013-03-05 22:18 ` Andrew Morton
2013-03-06 15:50 ` Oleg Nesterov [this message]
2013-03-06 20:18 ` Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306155039.GB7697@redhat.com \
--to=oleg@redhat.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=artem.savkov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=msb@chromium.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox