From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped Date: Mon, 11 Mar 2013 23:50:48 +0100 Message-ID: <20130311225048.GA3872@bremse> References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-2-git-send-email-yinghai@kernel.org> <20130308051059.GC14556@mtj.dyndns.org> <51398096.1060304@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ia0-f177.google.com ([209.85.210.177]:51488 "EHLO mail-ia0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506Ab3CKWvK (ORCPT ); Mon, 11 Mar 2013 18:51:10 -0400 Received: by mail-ia0-f177.google.com with SMTP id y25so4208426iay.22 for ; Mon, 11 Mar 2013 15:51:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <51398096.1060304@zytor.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "H. Peter Anvin" Cc: Tejun Heo , Yinghai Lu , Thomas Gleixner , Ingo Molnar , Andrew Morton , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , David Airlie , Jacob Shin , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org On Thu, Mar 07, 2013 at 10:09:26PM -0800, H. Peter Anvin wrote: > On 03/07/2013 09:28 PM, Tejun Heo wrote: > > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu wrote: > >> They are not using memblock_find_in_range(), so 1ULL<< will not help. > >> > >> Really hope i915 drm guys could clean that hacks. > > > > The code isn't being used. Just leave it alone. Maybe add a comment. > > The change is just making things more confusing. > > > > Indeed, but... > > Daniel: can you guys clean this up or can we just remove the #if 0 clause? I guess we could just put this into a comment explaining where stolen memory for the gfx devices is at on gen2. But tbh I don't mind if we just keep the #if 0 code around. For all newer platforms we can get at that offset through mch bar registers, so I don't really care. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch