From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] ACPI / I2C: Use parent's ACPI_HANDLE() in acpi_i2c_register_devices() Date: Mon, 1 Apr 2013 11:28:07 +0300 Message-ID: <20130401082807.GL21804@intel.com> References: <2966020.zlpeyGGUDW@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2966020.zlpeyGGUDW-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Jean Delvare List-Id: linux-acpi@vger.kernel.org On Mon, Apr 01, 2013 at 02:25:03AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > The ACPI handle of struct i2c_adapter's dev member should not be > set, because this causes that struct i2c_adapter to be associated > with the ACPI device node corresponding to its parent as the > second "physical_device", which is incorrect (this happens during > the registration of struct i2c_adapter). Consequently, > acpi_i2c_register_devices() should use the ACPI handle of the > parent of the struct i2c_adapter it is called for rather than the > struct i2c_adapter's ACPI handle (which should be NULL). > > Make that happen and modify the i2c-designware-platdrv driver, > which currently is the only driver for ACPI-enumerated I2C > controller chips, not to set the ACPI handle for the > struct i2c_adapter it creates. > > Signed-off-by: Rafael J. Wysocki Acked-by: Mika Westerberg