From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v2 2/2] mce: acpi/apei: Add a boot option to disable ff mode for corrected errors Date: Mon, 1 Jul 2013 17:38:06 +0200 Message-ID: <20130701153805.GB23539@pd.tnic> References: <20130621072725.GB22006@pd.tnic> <20130628120224.7781.45438.stgit@localhost.localdomain> <51D19B3F.3060405@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:53876 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250Ab3GAPiN (ORCPT ); Mon, 1 Jul 2013 11:38:13 -0400 Content-Disposition: inline In-Reply-To: <51D19B3F.3060405@linux.vnet.ibm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Naveen N. Rao" Cc: Tony Luck , ananth@in.ibm.com, masbock@linux.vnet.ibm.com, lcm@linux.vnet.ibm.com, Linux Kernel Mailing List , linux-acpi , Huang Ying On Mon, Jul 01, 2013 at 08:37:43PM +0530, Naveen N. Rao wrote: > On 06/28/2013 11:01 PM, Tony Luck wrote: > >>+ if (sec_sev == GHES_SEV_CORRECTED && > >>+ (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED) && > >>+ (mem_err->validation_bits & CPER_MEM_VALID_PHYSICAL_ADDRESS)) { > >>+ unsigned long pfn; > >>+ pfn = mem_err->physical_addr >> PAGE_SHIFT; > > > >As Reagan said "Trust ... but verify" ... we should make sure BIOS > >gave us a good pfn > > if (pfn_valid(pfn)) > > soft_memory_failure_queue(pfn, 0, 0); > > else > > printk( ...something about > >BIOS giving us bad pfn = %lu\n", pfn); > > Ah, nice catch - I thought soft_offline_page() takes care of this, > but it sure is good to point a finger at the firmware. While at it maybe make it pr_warning(FW_BUG or FW_WARN... -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --