From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Yinghai Lu <yinghai@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 3/8] PCI: acpiphp: enable_device(): rescan even if no new devices on slot
Date: Thu, 11 Jul 2013 08:11:44 +0300 [thread overview]
Message-ID: <20130711051144.GF4898@intel.com> (raw)
In-Reply-To: <1827270.u1sYdQ8l8y@vostro.rjw.lan>
On Thu, Jul 11, 2013 at 02:25:42AM +0200, Rafael J. Wysocki wrote:
> On Wednesday, July 03, 2013 05:04:50 PM Mika Westerberg wrote:
> > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
> >
> > pci_scan_slot() returns number of new devices connected *directly*
> > connected to the slot. Current enable_device() checks the return value
> > and stops if it doesn't see a new device.
> >
> > In Thunderbolt chaining case the new device can be deeper in hierarchy, so
> > do the rescan anyway.
> >
> > Because of that we must make sure that pcibios_resource_survey_bus() and
> > check_hotplug_bridge() get called only for a just found bus and not the
> > ones already added to the system. Failure to do so will lead to resource
> > conflicts.
>
> Well, I wonder what we're doing to this end, because there's nothing in that
> area in the patch?
We forgot to update the changelog of this patch. The last paragraph should
not be there.
next prev parent reply other threads:[~2013-07-11 5:06 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 14:04 [PATCH v2 0/8] Thunderbolt workarounds Mika Westerberg
2013-07-03 14:04 ` [PATCH v2 1/8] x86/PCI: prevent re-allocation of already existing bridge and ROM resources Mika Westerberg
2013-07-23 0:08 ` Bjorn Helgaas
2013-07-23 1:18 ` Bjorn Helgaas
2013-07-23 1:33 ` Bjorn Helgaas
2013-07-23 2:01 ` Rafael J. Wysocki
2013-07-23 1:50 ` Rafael J. Wysocki
2013-07-03 14:04 ` [PATCH v2 2/8] PCI: acpiphp: do not check for SLOT_ENABLED in enable_device() Mika Westerberg
2013-07-03 14:04 ` [PATCH v2 3/8] PCI: acpiphp: enable_device(): rescan even if no new devices on slot Mika Westerberg
2013-07-11 0:25 ` Rafael J. Wysocki
2013-07-11 5:11 ` Mika Westerberg [this message]
2013-07-11 22:48 ` Rafael J. Wysocki
2013-07-03 14:04 ` [PATCH v2 4/8] PCI: acpiphp: check for new devices on enabled host Mika Westerberg
2013-07-03 14:04 ` [PATCH v2 5/8] PCI: acpiphp: kill SLOT_ENABLED in favor of always re-enumerating the devices Mika Westerberg
2013-07-03 14:04 ` [PATCH v2 6/8] PCI: acpiphp: workaround for Thunderbolt on Acer Aspire S5 Mika Westerberg
2013-07-03 21:40 ` Rafael J. Wysocki
2013-07-04 8:58 ` Mika Westerberg
2013-07-04 12:36 ` Rafael J. Wysocki
2013-07-04 12:53 ` Mika Westerberg
2013-07-04 13:14 ` Rafael J. Wysocki
2013-07-04 13:33 ` Mika Westerberg
2013-07-04 13:53 ` Rafael J. Wysocki
2013-07-04 14:29 ` [PATCH v2.1 " Mika Westerberg
2013-07-04 23:48 ` Rafael J. Wysocki
2013-07-05 5:47 ` Mika Westerberg
2013-07-19 3:57 ` [PATCH v2 " Robert Hancock
2013-07-19 12:18 ` Rafael J. Wysocki
2013-07-03 21:45 ` Bjorn Helgaas
2013-07-03 21:58 ` Rafael J. Wysocki
2013-07-03 14:04 ` [PATCH v2 7/8] PCI: acpiphp: get rid of unused constants in acpiphp.h Mika Westerberg
2013-07-03 14:04 ` [PATCH v2 8/8] PCI: acpiphp: sanitize acpiphp_get_[latch|adapter]_status() Mika Westerberg
2013-07-03 18:29 ` [PATCH v2 0/8] Thunderbolt workarounds Matthew Garrett
2013-07-03 18:33 ` Greg Kroah-Hartman
2013-07-03 18:44 ` Matthew Garrett
2013-07-03 19:57 ` Ronciak, John
2013-07-03 20:35 ` Matthew Garrett
2013-07-03 20:46 ` Ronciak, John
2013-07-03 21:21 ` Matthew Garrett
2013-07-03 18:41 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130711051144.GF4898@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).