From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 14/21] x86, acpi, numa: Reserve hotpluggable memory at early time. Date: Tue, 23 Jul 2013 16:55:57 -0400 Message-ID: <20130723205557.GS21100@mtj.dyndns.org> References: <1374220774-29974-1-git-send-email-tangchen@cn.fujitsu.com> <1374220774-29974-15-git-send-email-tangchen@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1374220774-29974-15-git-send-email-tangchen@cn.fujitsu.com> Sender: owner-linux-mm@kvack.org To: Tang Chen Cc: tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, Jul 19, 2013 at 03:59:27PM +0800, Tang Chen wrote: > + /* > + * In such an early time, we don't have nid. We specify pxm > + * instead of MAX_NUMNODES to prevent memblock merging regions > + * on different nodes. And later modify pxm to nid when nid is > + * mapped so that we can arrange ZONE_MOVABLE on different > + * nodes. > + */ > + memblock_reserve_hotpluggable(base_address, length, pxm); This is rather hacky. Why not just introduce MEMBLOCK_NO_MERGE flag? -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org