From: Borislav Petkov <bp@alien8.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>, Borislav Petkov <bp@suse.de>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>, Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH] APEI/ERST: Fix error message formatting
Date: Mon, 29 Jul 2013 16:40:46 +0200 [thread overview]
Message-ID: <20130729144046.GE6634@pd.tnic> (raw)
In-Reply-To: <CAErSpo6fbMmicX95j_wYkJRnQeJEZ_jQSm76j9ZN4sHP0C2Yhg@mail.gmail.com>
On Mon, Jul 29, 2013 at 08:28:05AM -0600, Bjorn Helgaas wrote:
> > @@ -186,7 +186,7 @@ static int erst_exec_stall(struct apei_exec_context *ctx,
> >
> > if (ctx->value > FIRMWARE_MAX_STALL) {
> > if (!in_nmi())
> > - pr_warning(FW_WARN ERST_PFX
> > + pr_warn(FW_WARN
> > "Too long stall time for stall instruction: %llx.\n",
>
> You didn't change this part, but this and similar messages look less
> useful than they could be. We're printing in hex, but there's no
> indication in the output (no "0x" prefix). And there's no instruction
> pointer or anything to help connect this back to the source of the
> problem.
Sounds like we don't want to print ctx->value at all but simply signal
about the stall? Or?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-07-29 14:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:01 [PATCH] APEI/ERST: Fix error message formatting Borislav Petkov
2013-07-22 21:24 ` Kees Cook
2013-07-24 17:13 ` Naveen N. Rao
2013-07-24 17:23 ` Joe Perches
2013-07-25 11:23 ` Naveen N. Rao
2013-07-25 17:32 ` Bjorn Helgaas
2013-07-29 13:58 ` Borislav Petkov
2013-07-29 14:28 ` Bjorn Helgaas
2013-07-29 14:40 ` Borislav Petkov [this message]
2013-07-29 14:50 ` Bjorn Helgaas
2013-07-29 15:22 ` Borislav Petkov
2013-07-29 15:32 ` Joe Perches
2013-07-29 16:12 ` Bjorn Helgaas
2013-07-31 9:23 ` Borislav Petkov
2013-07-31 9:57 ` Naveen N. Rao
2013-07-31 9:46 ` Naveen N. Rao
2013-07-31 18:00 ` Bjorn Helgaas
2013-08-01 10:10 ` Naveen N. Rao
2013-07-24 18:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729144046.GE6634@pd.tnic \
--to=bp@alien8.de \
--cc=anton@enomsg.org \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=ccross@android.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).