From: Tejun Heo <tj@kernel.org>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl,
lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu,
hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de,
yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org,
mina86@mina86.com, gong.chen@linux.intel.com,
vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com,
riel@redhat.com, jweiner@redhat.com, prarit@redhat.com,
zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com,
x86@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH part2 2/4] earlycpio.c: Fix the confusing comment of find_cpio_data().
Date: Mon, 12 Aug 2013 10:17:18 -0400 [thread overview]
Message-ID: <20130812141718.GE15892@htj.dyndns.org> (raw)
In-Reply-To: <1375938239-18769-3-git-send-email-tangchen@cn.fujitsu.com>
On Thu, Aug 08, 2013 at 01:03:57PM +0800, Tang Chen wrote:
> The comments of find_cpio_data() says:
>
> * @offset: When a matching file is found, this is the offset to the
> * beginning of the cpio. ......
>
> But according to the code,
>
> dptr = PTR_ALIGN(p + ch[C_NAMESIZE], 4);
> nptr = PTR_ALIGN(dptr + ch[C_FILESIZE], 4);
> ....
> *offset = (long)nptr - (long)data; /* data is the cpio file */
>
> @offset is the offset of the next file, not the matching file itself.
> This is confused and may cause unnecessary waste of time to debug.
> So fix it.
>
> v1 -> v2:
> As tj suggested, rename @offset to @nextoff which is more clear to
> users. And also adjust the new comments.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2013-08-12 14:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 5:03 [PATCH part2 0/4] acpi: Trivial fix and improving for memory hotplug Tang Chen
2013-08-08 5:03 ` [PATCH part2 1/4] acpi: Print Hot-Pluggable Field in SRAT Tang Chen
2013-08-12 14:15 ` Tejun Heo
2013-08-12 14:25 ` Tang Chen
2013-08-08 5:03 ` [PATCH part2 2/4] earlycpio.c: Fix the confusing comment of find_cpio_data() Tang Chen
2013-08-12 14:17 ` Tejun Heo [this message]
2013-08-08 5:03 ` [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE() Tang Chen
2013-08-08 5:27 ` Joe Perches
2013-08-08 12:18 ` Tang Chen
2013-08-08 14:09 ` Joe Perches
2013-08-12 14:21 ` Tejun Heo
2013-08-12 14:25 ` Tang Chen
2013-08-08 5:03 ` [PATCH part2 4/4] acpi: Introduce acpi_verify_initrd() to check if a table is invalid Tang Chen
2013-08-08 14:09 ` [PATCH part2 0/4] acpi: Trivial fix and improving for memory hotplug Rafael J. Wysocki
2013-08-09 0:37 ` Tang Chen
2013-08-09 13:36 ` Rafael J. Wysocki
2013-08-09 15:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812141718.GE15892@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=jweiner@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lv.zheng@intel.com \
--cc=lwoodman@redhat.com \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@elte.hu \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=trenn@suse.de \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yinghai@kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).