From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH part2 2/4] earlycpio.c: Fix the confusing comment of find_cpio_data(). Date: Mon, 12 Aug 2013 10:17:18 -0400 Message-ID: <20130812141718.GE15892@htj.dyndns.org> References: <1375938239-18769-1-git-send-email-tangchen@cn.fujitsu.com> <1375938239-18769-3-git-send-email-tangchen@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1375938239-18769-3-git-send-email-tangchen@cn.fujitsu.com> Sender: linux-doc-owner@vger.kernel.org To: Tang Chen Cc: robert.moore@intel.com, lv.zheng@intel.com, rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, zhangyanfei@cn.fujitsu.com, yanghy@cn.fujitsu.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Thu, Aug 08, 2013 at 01:03:57PM +0800, Tang Chen wrote: > The comments of find_cpio_data() says: > > * @offset: When a matching file is found, this is the offset to the > * beginning of the cpio. ...... > > But according to the code, > > dptr = PTR_ALIGN(p + ch[C_NAMESIZE], 4); > nptr = PTR_ALIGN(dptr + ch[C_FILESIZE], 4); > .... > *offset = (long)nptr - (long)data; /* data is the cpio file */ > > @offset is the offset of the next file, not the matching file itself. > This is confused and may cause unnecessary waste of time to debug. > So fix it. > > v1 -> v2: > As tj suggested, rename @offset to @nextoff which is more clear to > users. And also adjust the new comments. > > Signed-off-by: Tang Chen > Reviewed-by: Zhang Yanfei Reviewed-by: Tejun Heo Thanks. -- tejun