From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 3/3] mce: acpi/apei: trace: Enable ghes memory error trace event Date: Tue, 13 Aug 2013 09:41:47 -0300 Message-ID: <20130813094147.062317f8@concha.lan> References: <1375986471-27113-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <1375986471-27113-4-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <20130808163822.67e0828a@samsung.com> <20130810180322.GC4155@pd.tnic> <20130812083355.47c1bae8@samsung.com> <5208D80D.5030206@linux.vnet.ibm.com> <20130812114404.3bd64fa0@samsung.com> <520A1B5E.8040105@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <520A1B5E.8040105@linux.vnet.ibm.com> Sender: linux-pci-owner@vger.kernel.org To: "Naveen N. Rao" Cc: Borislav Petkov , tony.luck@intel.com, bhelgaas@google.com, rostedt@goodmis.org, rjw@sisk.pl, lance.ortiz@hp.com, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Aristeu Rozanski Filho List-Id: linux-acpi@vger.kernel.org Em Tue, 13 Aug 2013 17:11:18 +0530 "Naveen N. Rao" escreveu: > On 08/12/2013 08:14 PM, Mauro Carvalho Chehab wrote: > >> But, this only seems to expose the APEI data as a string > >> and doesn't look to really make all the fields available to user-space > >> in a raw manner. Not sure how well this can be utilised by a user-space > >> tool. Do you have suggestions on how we can do this? > > > > There's already an userspace tool that handes it: > > https://git.fedorahosted.org/cgit/rasdaemon.git/ > > > > What is missing there on the current version is the bits that would allow > > to translate from APEI way to report an error (memory node, card, module, > > bank, device) into a DIMM label[1]. > > If I'm reading this right, all APEI data seems to be squashed into a > string in mc_event. Yes. We had lots of discussion about how to map memory errors over the last couple years. Basically, it was decided that the information that could be decoded into a DIMM to be mapped as integers, and all other driver-specific data to be added as strings. On the tests I did, different machines/vendors fill the APEI data on a different way, with makes harder to associate them to a DIMM. > Also, the fru id/text don't seem to be passed to user-space. That's likely because on the systems I tested, those fields were not filled (or maybe they appeared on a latter ACPI version). We should add them also the same string as the other fields there at ghes_edac. Regards, Mauro