* [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
@ 2013-08-17 1:26 Jerry Snitselaar
2013-08-19 6:16 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-17 1:26 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi, mika.westerberg, rjw
Without MODULE_LICENSE set, I get the following with modprobe:
acpi_i2c: module license 'unspecified' taints kernel.
acpi_i2c: Unknown symbol i2c_new_device (err 0)
acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
---
drivers/acpi/acpi_i2c.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c
index 82045e3..2c5c65d 100644
--- a/drivers/acpi/acpi_i2c.c
+++ b/drivers/acpi/acpi_i2c.c
@@ -14,9 +14,14 @@
#include <linux/export.h>
#include <linux/i2c.h>
#include <linux/ioport.h>
+#include <linux/module.h>
ACPI_MODULE_NAME("i2c");
+MODULE_DESCRIPTION("ACPI I2C enumeration support");
+MODULE_AUTHOR("Mika Westerberg");
+MODULE_LICENSE("GPL");
+
static int acpi_i2c_add_resource(struct acpi_resource *ares, void *data)
{
struct i2c_board_info *info = data;
--
1.8.4.rc3.2.g2c2b664
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-17 1:26 [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION Jerry Snitselaar
@ 2013-08-19 6:16 ` Mika Westerberg
2013-08-19 23:30 ` Rafael J. Wysocki
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2013-08-19 6:16 UTC (permalink / raw)
To: Jerry Snitselaar; +Cc: linux-kernel, linux-acpi, rjw
On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> Without MODULE_LICENSE set, I get the following with modprobe:
>
> acpi_i2c: module license 'unspecified' taints kernel.
> acpi_i2c: Unknown symbol i2c_new_device (err 0)
> acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
>
> Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
Looks good to me.
Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-19 6:16 ` Mika Westerberg
@ 2013-08-19 23:30 ` Rafael J. Wysocki
2013-08-19 23:35 ` Jerry Snitselaar
0 siblings, 1 reply; 13+ messages in thread
From: Rafael J. Wysocki @ 2013-08-19 23:30 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jerry Snitselaar, linux-kernel, linux-acpi
On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > Without MODULE_LICENSE set, I get the following with modprobe:
> >
> > acpi_i2c: module license 'unspecified' taints kernel.
> > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> >
> > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
>
> Looks good to me.
>
> Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
Well, OK, but do we need to be able to build that as a module?
Maybe it should just be yes or no?
Rafael
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-19 23:30 ` Rafael J. Wysocki
@ 2013-08-19 23:35 ` Jerry Snitselaar
2013-08-19 23:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-19 23:35 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Mika Westerberg, linux-kernel, linux-acpi
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > Without MODULE_LICENSE set, I get the following with modprobe:
> > >
> > > acpi_i2c: module license 'unspecified' taints kernel.
> > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > >
> > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> >
> > Looks good to me.
> >
> > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
>
> Well, OK, but do we need to be able to build that as a module?
>
> Maybe it should just be yes or no?
>
> Rafael
>
Perhaps have depends on I2C=y and be a bool instead of tristate?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-19 23:35 ` Jerry Snitselaar
@ 2013-08-19 23:48 ` Rafael J. Wysocki
2013-08-20 3:34 ` Jerry Snitselaar
0 siblings, 1 reply; 13+ messages in thread
From: Rafael J. Wysocki @ 2013-08-19 23:48 UTC (permalink / raw)
To: Jerry Snitselaar; +Cc: Mika Westerberg, linux-kernel, linux-acpi
On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > >
> > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > >
> > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > >
> > > Looks good to me.
> > >
> > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> >
> > Well, OK, but do we need to be able to build that as a module?
> >
> > Maybe it should just be yes or no?
> >
> > Rafael
> >
>
> Perhaps have depends on I2C=y and be a bool instead of tristate?
Yes, that's the idea.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-19 23:48 ` Rafael J. Wysocki
@ 2013-08-20 3:34 ` Jerry Snitselaar
2013-08-20 7:28 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-20 3:34 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Mika Westerberg, linux-kernel, linux-acpi
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > >
> > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > >
> > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > >
> > > > Looks good to me.
> > > >
> > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > >
> > > Well, OK, but do we need to be able to build that as a module?
> > >
> > > Maybe it should just be yes or no?
> > >
> > > Rafael
> > >
> >
> > Perhaps have depends on I2C=y and be a bool instead of tristate?
>
> Yes, that's the idea.
>
Does this look okay Mika?
[PATCH] acpi_i2c: do not build as loadable module
Change from tristate to bool, and depend on I2C=y
Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
---
drivers/acpi/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 100bd72..183a309 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -181,8 +181,9 @@ config ACPI_DOCK
drive bays such as the IBM Ultrabay and the Dell Module Bay.
config ACPI_I2C
- def_tristate I2C
- depends on I2C
+ bool "I2C"
+ depends on I2C=y
+ default n
help
ACPI I2C enumeration support.
--
1.8.4.rc3.2.g2c2b664
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-20 3:34 ` Jerry Snitselaar
@ 2013-08-20 7:28 ` Mika Westerberg
2013-08-20 8:00 ` Jerry Snitselaar
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2013-08-20 7:28 UTC (permalink / raw)
To: Jerry Snitselaar; +Cc: Rafael J. Wysocki, linux-kernel, linux-acpi
On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > > >
> > > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > > >
> > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > > >
> > > > > Looks good to me.
> > > > >
> > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > > >
> > > > Well, OK, but do we need to be able to build that as a module?
> > > >
> > > > Maybe it should just be yes or no?
> > > >
> > > > Rafael
> > > >
> > >
> > > Perhaps have depends on I2C=y and be a bool instead of tristate?
> >
> > Yes, that's the idea.
> >
> Does this look okay Mika?
>
> [PATCH] acpi_i2c: do not build as loadable module
>
> Change from tristate to bool, and depend on I2C=y
I'm not sure about this. Does the below mean that we can't build the ACPI
I2C enumeration at all if I2C core is compiled as module?
>
> Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> ---
> drivers/acpi/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 100bd72..183a309 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -181,8 +181,9 @@ config ACPI_DOCK
> drive bays such as the IBM Ultrabay and the Dell Module Bay.
>
> config ACPI_I2C
> - def_tristate I2C
> - depends on I2C
> + bool "I2C"
> + depends on I2C=y
> + default n
> help
> ACPI I2C enumeration support.
>
> --
> 1.8.4.rc3.2.g2c2b664
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-20 7:28 ` Mika Westerberg
@ 2013-08-20 8:00 ` Jerry Snitselaar
2013-08-20 8:14 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-20 8:00 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Rafael J. Wysocki, linux-kernel, linux-acpi
On Tue Aug 20 13, Mika Westerberg wrote:
> On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > > > >
> > > > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > > > >
> > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > > > >
> > > > > > Looks good to me.
> > > > > >
> > > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > > > >
> > > > > Well, OK, but do we need to be able to build that as a module?
> > > > >
> > > > > Maybe it should just be yes or no?
> > > > >
> > > > > Rafael
> > > > >
> > > >
> > > > Perhaps have depends on I2C=y and be a bool instead of tristate?
> > >
> > > Yes, that's the idea.
> > >
> > Does this look okay Mika?
> >
> > [PATCH] acpi_i2c: do not build as loadable module
> >
> > Change from tristate to bool, and depend on I2C=y
>
> I'm not sure about this. Does the below mean that we can't build the ACPI
> I2C enumeration at all if I2C core is compiled as module?
Yes, that was what Rafael was suggesting. If the ability to compile as
a module if I2C is a module is needed, then we need the 1st patch.
Jerry
>
> >
> > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > ---
> > drivers/acpi/Kconfig | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> > index 100bd72..183a309 100644
> > --- a/drivers/acpi/Kconfig
> > +++ b/drivers/acpi/Kconfig
> > @@ -181,8 +181,9 @@ config ACPI_DOCK
> > drive bays such as the IBM Ultrabay and the Dell Module Bay.
> >
> > config ACPI_I2C
> > - def_tristate I2C
> > - depends on I2C
> > + bool "I2C"
> > + depends on I2C=y
> > + default n
> > help
> > ACPI I2C enumeration support.
> >
> > --
> > 1.8.4.rc3.2.g2c2b664
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-20 8:00 ` Jerry Snitselaar
@ 2013-08-20 8:14 ` Mika Westerberg
2013-08-20 8:18 ` Mika Westerberg
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2013-08-20 8:14 UTC (permalink / raw)
To: Jerry Snitselaar; +Cc: Rafael J. Wysocki, linux-kernel, linux-acpi
On Tue, Aug 20, 2013 at 01:00:08AM -0700, Jerry Snitselaar wrote:
> On Tue Aug 20 13, Mika Westerberg wrote:
> > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > > > > >
> > > > > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > > > > >
> > > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > > > > >
> > > > > > > Looks good to me.
> > > > > > >
> > > > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > > > > >
> > > > > > Well, OK, but do we need to be able to build that as a module?
> > > > > >
> > > > > > Maybe it should just be yes or no?
> > > > > >
> > > > > > Rafael
> > > > > >
> > > > >
> > > > > Perhaps have depends on I2C=y and be a bool instead of tristate?
> > > >
> > > > Yes, that's the idea.
> > > >
> > > Does this look okay Mika?
> > >
> > > [PATCH] acpi_i2c: do not build as loadable module
> > >
> > > Change from tristate to bool, and depend on I2C=y
> >
> > I'm not sure about this. Does the below mean that we can't build the ACPI
> > I2C enumeration at all if I2C core is compiled as module?
>
> Yes, that was what Rafael was suggesting. If the ability to compile as
> a module if I2C is a module is needed, then we need the 1st patch.
In that case I would prefer the first patch. Otherwise we lose the ability
to enumerate I2C devices from ACPI namespace on some distros (at least
Debian builds I2C core as a module).
Rafael?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-20 8:14 ` Mika Westerberg
@ 2013-08-20 8:18 ` Mika Westerberg
2013-08-20 12:38 ` Rafael J. Wysocki
0 siblings, 1 reply; 13+ messages in thread
From: Mika Westerberg @ 2013-08-20 8:18 UTC (permalink / raw)
To: Jerry Snitselaar; +Cc: Rafael J. Wysocki, linux-kernel, linux-acpi
On Tue, Aug 20, 2013 at 11:14:42AM +0300, Mika Westerberg wrote:
> On Tue, Aug 20, 2013 at 01:00:08AM -0700, Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Mika Westerberg wrote:
> > > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > > > > > >
> > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > > > > > >
> > > > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > > > > > >
> > > > > > > > Looks good to me.
> > > > > > > >
> > > > > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > > > > > >
> > > > > > > Well, OK, but do we need to be able to build that as a module?
> > > > > > >
> > > > > > > Maybe it should just be yes or no?
> > > > > > >
> > > > > > > Rafael
> > > > > > >
> > > > > >
> > > > > > Perhaps have depends on I2C=y and be a bool instead of tristate?
> > > > >
> > > > > Yes, that's the idea.
> > > > >
> > > > Does this look okay Mika?
> > > >
> > > > [PATCH] acpi_i2c: do not build as loadable module
> > > >
> > > > Change from tristate to bool, and depend on I2C=y
> > >
> > > I'm not sure about this. Does the below mean that we can't build the ACPI
> > > I2C enumeration at all if I2C core is compiled as module?
> >
> > Yes, that was what Rafael was suggesting. If the ability to compile as
> > a module if I2C is a module is needed, then we need the 1st patch.
>
> In that case I would prefer the first patch. Otherwise we lose the ability
> to enumerate I2C devices from ACPI namespace on some distros (at least
> Debian builds I2C core as a module).
>
> Rafael?
Actually there's a patch that moves DT I2C helpers to the I2C core here:
https://lkml.org/lkml/2013/8/19/349
we should probably do the same for the ACPI case. Doing that solves this
problem as well.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-20 8:18 ` Mika Westerberg
@ 2013-08-20 12:38 ` Rafael J. Wysocki
0 siblings, 0 replies; 13+ messages in thread
From: Rafael J. Wysocki @ 2013-08-20 12:38 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jerry Snitselaar, linux-kernel, linux-acpi
On Tuesday, August 20, 2013 11:18:52 AM Mika Westerberg wrote:
> On Tue, Aug 20, 2013 at 11:14:42AM +0300, Mika Westerberg wrote:
> > On Tue, Aug 20, 2013 at 01:00:08AM -0700, Jerry Snitselaar wrote:
> > > On Tue Aug 20 13, Mika Westerberg wrote:
> > > > On Mon, Aug 19, 2013 at 08:34:03PM -0700, Jerry Snitselaar wrote:
> > > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > > > > > > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > > > > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > > > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > > > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > > > > > > >
> > > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > > > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > > > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > > > > > > >
> > > > > > > > > Looks good to me.
> > > > > > > > >
> > > > > > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > > > > > > >
> > > > > > > > Well, OK, but do we need to be able to build that as a module?
> > > > > > > >
> > > > > > > > Maybe it should just be yes or no?
> > > > > > > >
> > > > > > > > Rafael
> > > > > > > >
> > > > > > >
> > > > > > > Perhaps have depends on I2C=y and be a bool instead of tristate?
> > > > > >
> > > > > > Yes, that's the idea.
> > > > > >
> > > > > Does this look okay Mika?
> > > > >
> > > > > [PATCH] acpi_i2c: do not build as loadable module
> > > > >
> > > > > Change from tristate to bool, and depend on I2C=y
> > > >
> > > > I'm not sure about this. Does the below mean that we can't build the ACPI
> > > > I2C enumeration at all if I2C core is compiled as module?
> > >
> > > Yes, that was what Rafael was suggesting. If the ability to compile as
> > > a module if I2C is a module is needed, then we need the 1st patch.
> >
> > In that case I would prefer the first patch. Otherwise we lose the ability
> > to enumerate I2C devices from ACPI namespace on some distros (at least
> > Debian builds I2C core as a module).
> >
> > Rafael?
>
> Actually there's a patch that moves DT I2C helpers to the I2C core here:
>
> https://lkml.org/lkml/2013/8/19/349
>
> we should probably do the same for the ACPI case. Doing that solves this
> problem as well.
Yes, and I'd prefer it to be done this way. Having ACPI support as a separate
module doesn't really buy us anything.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
@ 2013-08-16 21:40 Jerry Snitselaar
2013-08-17 5:12 ` Jerry Snitselaar
0 siblings, 1 reply; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-16 21:40 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi, mika.westerberg, rjw
Without MODULE_LICENSE get, I get the following with modprobe:
acpi_i2c: module license 'unspecified' taints kernel.
acpi_i2c: Unknown symbol i2c_new_device (err 0)
acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
---
drivers/acpi/acpi_i2c.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c
index 82045e3..2c5c65d 100644
--- a/drivers/acpi/acpi_i2c.c
+++ b/drivers/acpi/acpi_i2c.c
@@ -14,9 +14,14 @@
#include <linux/export.h>
#include <linux/i2c.h>
#include <linux/ioport.h>
+#include <linux/module.h>
ACPI_MODULE_NAME("i2c");
+MODULE_DESCRIPTION("ACPI I2C enumeration support");
+MODULE_AUTHOR("Mika Westerberg");
+MODULE_LICENSE("GPL");
+
static int acpi_i2c_add_resource(struct acpi_resource *ares, void *data)
{
struct i2c_board_info *info = data;
--
1.8.4.rc3.2.g2c2b664
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
2013-08-16 21:40 Jerry Snitselaar
@ 2013-08-17 5:12 ` Jerry Snitselaar
0 siblings, 0 replies; 13+ messages in thread
From: Jerry Snitselaar @ 2013-08-17 5:12 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi, mika.westerberg, rjw
Sorry for the double send. This one was apparently blocked by the
greylisting on vger.kernel.org and it was hours before I received
notification of that. I forgot to bcc myself and had no record of the
git send-email successfully completing. Just ignore this patch.
Jerry
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-08-20 12:38 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-17 1:26 [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION Jerry Snitselaar
2013-08-19 6:16 ` Mika Westerberg
2013-08-19 23:30 ` Rafael J. Wysocki
2013-08-19 23:35 ` Jerry Snitselaar
2013-08-19 23:48 ` Rafael J. Wysocki
2013-08-20 3:34 ` Jerry Snitselaar
2013-08-20 7:28 ` Mika Westerberg
2013-08-20 8:00 ` Jerry Snitselaar
2013-08-20 8:14 ` Mika Westerberg
2013-08-20 8:18 ` Mika Westerberg
2013-08-20 12:38 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2013-08-16 21:40 Jerry Snitselaar
2013-08-17 5:12 ` Jerry Snitselaar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox