From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 4/5] x86, mem-hotplug: Support initialize page tables from low to high. Date: Mon, 23 Sep 2013 11:53:31 -0400 Message-ID: <20130923155331.GE14547@htj.dyndns.org> References: <1379064655-20874-1-git-send-email-tangchen@cn.fujitsu.com> <1379064655-20874-5-git-send-email-tangchen@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ye0-f170.google.com ([209.85.213.170]:47968 "EHLO mail-ye0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752776Ab3IWPxg (ORCPT ); Mon, 23 Sep 2013 11:53:36 -0400 Content-Disposition: inline In-Reply-To: <1379064655-20874-5-git-send-email-tangchen@cn.fujitsu.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tang Chen Cc: rjw@sisk.pl, lenb@kernel.org, tglx@linutronix.de, mingo@elte.hu, hpa@zytor.com, akpm@linux-foundation.org, toshi.kani@hp.com, zhangyanfei@cn.fujitsu.com, liwanp@linux.vnet.ibm.com, trenn@suse.de, yinghai@kernel.org, jiang.liu@huawei.com, wency@cn.fujitsu.com, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, izumi.taku@jp.fujitsu.com, mgorman@suse.de, minchan@kernel.org, mina86@mina86.com, gong.chen@linux.intel.com, vasilis.liaskovitis@profitbricks.com, lwoodman@redhat.com, riel@redhat.com, jweiner@redhat.com, prarit@redhat.com, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org Hey, On Fri, Sep 13, 2013 at 05:30:54PM +0800, Tang Chen wrote: > init_mem_mapping() is called before SRAT is parsed. And memblock will allocate > memory for page tables. To prevent page tables being allocated within hotpluggable > memory, we will allocate page tables from the end of kernel image to the higher > memory. The same comment about patch split as before. Please make splitting out memory_map_from_high() a separate patch. Also, please choose one pair to describe the direction. The series is currently using four variants - top_down/bottom_up, high_to_low/low_to_high, from_high/from_low. rev/[none]. Please choose one and stick with it. Thanks. -- tejun