From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] acpi: update win8 OSI blacklist Date: Sun, 6 Oct 2013 21:59:28 +0100 Message-ID: <20131006205928.GA20296@srcf.ucam.org> References: <1380820383-23336-1-git-send-email-felipe.contreras@gmail.com> <20131004161226.GA22784@srcf.ucam.org> <20131006203353.GA19795@srcf.ucam.org> <20131006204518.GA20077@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:55743 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754136Ab3JFU7b (ORCPT ); Sun, 6 Oct 2013 16:59:31 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Felipe Contreras Cc: Linux Kernel Mailing List , ACPI Devel Maling List , "Rafael J. Wysocki" On Sun, Oct 06, 2013 at 03:51:05PM -0500, Felipe Contreras wrote: > On Sun, Oct 6, 2013 at 3:45 PM, Matthew Garrett wrote: > > On Sun, Oct 06, 2013 at 03:40:42PM -0500, Felipe Contreras wrote: > > > >> In case you didn't hear, the plan was to add an entry if a user > >> reports the backlight not working correctly, and acpi_osi="!Windows > >> 2012" fixing it with no negative effects. and that's what users did in > >> bug #60682. > > > > So add that to each entry you're adding to the list. > > No. These entries are already there, I'm merely updating it. I added a > comment before the list, but the comment was removed. There's no point in having a comment that describes a list, because someone will inevitably reorder them or insert things in between at some point. Add a comment per entry. -- Matthew Garrett | mjg59@srcf.ucam.org