From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] acpi: update win8 OSI blacklist Date: Mon, 7 Oct 2013 00:57:02 +0100 Message-ID: <20131006235702.GA21738@srcf.ucam.org> References: <20131004161226.GA22784@srcf.ucam.org> <20131006203353.GA19795@srcf.ucam.org> <20131006204518.GA20077@srcf.ucam.org> <20131006205928.GA20296@srcf.ucam.org> <20131006233106.GA21562@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:56896 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754896Ab3JFX5E (ORCPT ); Sun, 6 Oct 2013 19:57:04 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Felipe Contreras Cc: Linux Kernel Mailing List , ACPI Devel Maling List , "Rafael J. Wysocki" On Sun, Oct 06, 2013 at 06:36:57PM -0500, Felipe Contreras wrote: > On Sun, Oct 6, 2013 at 6:31 PM, Matthew Garrett wrote: > > On Sun, Oct 06, 2013 at 06:27:28PM -0500, Felipe Contreras wrote: > >> From acpi_osi_dmi_table: > >> > >> /* > >> * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. > >> * Linux ignores it, except for the machines enumerated below. > >> */ > > > > Which was a mistake. We learn from mistakes rather than repeating them. > > According to you. Cool. Look at that file and, without resorting to git blame, tell me why each of those entries is there. If your answer is "Just use git blame", then that's fine up until the point where someone reformats the list or decides to change the order and now it's still *possible* it's just really annoying, so why not just add the comments? They're cheap and you could have done it trivially in the time it's taken you to reply to this thread. -- Matthew Garrett | mjg59@srcf.ucam.org