From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 6/8] ACPI, APEI, CPER: Enhance memory reporting capability Date: Fri, 11 Oct 2013 17:49:38 +0200 Message-ID: <20131011154938.GK5925@pd.tnic> References: <1381473166-29303-1-git-send-email-gong.chen@linux.intel.com> <1381473166-29303-7-git-send-email-gong.chen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:55060 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754926Ab3JKPtp (ORCPT ); Fri, 11 Oct 2013 11:49:45 -0400 Content-Disposition: inline In-Reply-To: <1381473166-29303-7-git-send-email-gong.chen@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Chen, Gong" Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Fri, Oct 11, 2013 at 02:32:44AM -0400, Chen, Gong wrote: > After H/W error happens under FFM enabled mode, lots of information > are shown but some important parts like DIMM location missed. This > patch is used to show these extra fileds. > > Original-author: Tony Luck > Signed-off-by: Chen, Gong > --- > drivers/acpi/apei/cper.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c > index 680230c..2a4389f 100644 > --- a/drivers/acpi/apei/cper.c > +++ b/drivers/acpi/apei/cper.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -210,6 +211,8 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem) > printk("%s""card: %d\n", pfx, mem->card); > if (mem->validation_bits & CPER_MEM_VALID_MODULE) > printk("%s""module: %d\n", pfx, mem->module); > + if (mem->validation_bits & CPER_MEM_VALID_RANK_NUMBER) > + printk("%s""rank: %d\n", pfx, mem->rank); > if (mem->validation_bits & CPER_MEM_VALID_BANK) > printk("%s""bank: %d\n", pfx, mem->bank); > if (mem->validation_bits & CPER_MEM_VALID_DEVICE) > @@ -232,6 +235,15 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem) > etype < ARRAY_SIZE(cper_mem_err_type_strs) ? > cper_mem_err_type_strs[etype] : "unknown"); > } > + if (mem->validation_bits & CPER_MEM_VALID_MODULE_HANDLE) { > + const char *bank = NULL, *device = NULL; > + dmi_memdev_name(mem->mem_dev_handle, &bank, &device); > + if (bank != NULL && device != NULL) > + printk("%s""DIMM location: %s %s", pfx, bank, device); > + else > + printk("%s""DIMM DMI handle: 0x%.4x", pfx, > + mem->mem_dev_handle); Just a nitpick: maybe better arg alignment: printk("%s""DIMM DMI handle: 0x%.4x", pfx, mem->mem_dev_handle); -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --