From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices
Date: Sat, 12 Oct 2013 08:04:13 +0300 [thread overview]
Message-ID: <20131012050413.GY3521@intel.com> (raw)
In-Reply-To: <2393462.4JRAMNeigd@vostro.rjw.lan>
On Sat, Oct 12, 2013 at 12:16:02AM +0200, Rafael J. Wysocki wrote:
> > I think that this is intentional. We don't want that the i2c modalias
> > matches with the ACPI device (like with the i2c:INTABCD). Instead use ACPI
> > IDs that are added to the driver to match with the ACPI device.
>
> Well, I'm not really sure this was intentional, but I wonder how other bus
> types work in that respect?
We have the same for platform bus, if that's what you are asking.
It probably doesn't hurt to have this patch applied but it might cause
inadvertent match if for some reason there is an I2C client driver that
happens to have INTABCD I2C id in its list.
next prev parent reply other threads:[~2013-10-12 4:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 14:17 [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices Jarkko Nikula
[not found] ` <1381414669-26115-1-git-send-email-jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-11 14:49 ` Mika Westerberg
[not found] ` <20131011144946.GS3521-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-10-11 22:16 ` Rafael J. Wysocki
2013-10-12 5:04 ` Mika Westerberg [this message]
[not found] ` <20131012050413.GY3521-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-10-12 13:45 ` Rafael J. Wysocki
[not found] ` <2878883.SYGmCkS5Bt-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-10-12 16:18 ` Mika Westerberg
2013-10-14 6:45 ` Jarkko Nikula
[not found] ` <525B9321.5000906-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2013-10-14 8:16 ` Mika Westerberg
2013-10-14 6:34 ` Jarkko Nikula
2013-10-14 8:13 ` Mika Westerberg
2013-10-14 9:23 ` Zhang Rui
2013-10-14 11:18 ` Jarkko Nikula
2013-10-14 12:47 ` Zhang Rui
2013-10-15 11:44 ` Zhang Rui
2013-10-15 20:37 ` Rafael J. Wysocki
[not found] ` <12043671.FjbAvIiH5B-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2013-10-15 20:48 ` Greg Kroah-Hartman
2013-10-15 21:24 ` Rafael J. Wysocki
2013-10-15 23:31 ` Greg Kroah-Hartman
2013-10-15 23:47 ` Rafael J. Wysocki
2013-10-16 0:04 ` Grant Likely
[not found] ` <CACxGe6v3JHLKHqBXux=1mgm227S2dLafaqohKvzqsw1uo6tHyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-16 0:10 ` Greg Kroah-Hartman
2013-10-16 7:16 ` Jarkko Nikula
[not found] ` <20131015204829.GA5212-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-10-15 21:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012050413.GY3521@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).