From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 7/8] ACPI, APEI, CPER: Cleanup CPER memory error output format Date: Mon, 14 Oct 2013 12:36:16 +0200 Message-ID: <20131014103616.GE4009@pd.tnic> References: <1381473166-29303-1-git-send-email-gong.chen@linux.intel.com> <1381473166-29303-8-git-send-email-gong.chen@linux.intel.com> <20131011160208.GL5925@pd.tnic> <20131014045500.GC12189@gchen.bj.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:42314 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754583Ab3JNKg1 (ORCPT ); Mon, 14 Oct 2013 06:36:27 -0400 Content-Disposition: inline In-Reply-To: <20131014045500.GC12189@gchen.bj.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Chen Gong Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On Mon, Oct 14, 2013 at 12:55:00AM -0400, Chen Gong wrote: > Because most of data in CPER are empty or unimportant. It is not about whether it is important or not - the question is whether changing existing functionality which someone might rely upon is a problem here? Someone might be expecting exactly those messages to appear in dmesg. Btw, what is the real reason for this patch, to save yourself the output in dmesg? If so, you can disable this output when eMCA module has been loaded but leave it intact otherwise. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --