Re: [PATCH v2 9/9] ACPI / trace: Add trace interface for eMCA driver

Borislav Petkov
2013-10-16T17:29:20Z

On Wed, Oct 16, 2013 at 10:56:06AM -0400, Chen, Gong wrote:
> Use trace interface to elaborate all H/W error related
> information.
>
> v2 -> v1: move trace interface into ras_event.h
>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> ---

Just a nitpick below. Other than that:

Acked-by: Borislav Petkov <bp@suse.de>

> diff --git a/drivers/acpi/extlog_trace.h b/drivers/acpi/extlog_trace.h
> new file mode 100644
> index 0000000..67bb2c5
> --- /dev/null
> +++ b/drivers/acpi/extlog_trace.h
> @@ -0,0 +1,16 @@
> +#ifndef __DEBUG_EXTLOG_H
> +#define __DEBUG_EXTLOG_H
> +
> +#include <linux/cper.h>
> +
> +#ifdef CONFIG_EXTLOG_TRACE
> +extern void trace_mem_error(const uuid_le *fru_id, char *fru_text,
> + u64 err_count, u32 severity, struct cper_sec_mem_err *mem);

Applying: ACPI / trace: Add trace interface for eMCA driver
CHECK: extern prototypes should be avoided in .h files
#265: FILE: drivers/acpi/extlog_trace.h:7:
+extern void trace_mem_error(const uuid_le *fru_id, char *fru_text,

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--