Re: [PATCH v2 0/9] Extended H/W error log driver

Borislav Petkov
2013-10-16T18:00:38Z

On Wed, Oct 16, 2013 at 12:56:46PM -0400, Steven Rostedt wrote:
> On Wed, 16 Oct 2013 18:05:50 +0200
> Borislav Petkov <bp@alien8.de> wrote:
>
>
> > > For trace output format we still need further discussion. In the last
> > > patch(support trace interface) I have to reserve previous Kconfig
> > > format because I find once I put trace_event interface in the module,
> > > it will not work. I will paste another trace patch(it only works when
>
> What did not work?
>
> > > acpi_extlog is builtin) for your answer.
> >
> > I think to be able to define TRACE_EVENTs in modules, you need
> > https://lwn.net/Articles/383362/
> >
> > Steve, that still true?
> >
>
> Take a look at samples/trace_events/
>
> That's a module that uses TRACE_EVENTs.
>
> What exactly is the problem here?

Right, the only difference I can see is that include/ras/ras_event.h
doesn't have those below:

#undef TRACE_INCLUDE_PATH
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_PATH .

Perhaps that is the problem?

Gong, what is exactly the issue you're observing?

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--