From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v2 7/9] ACPI, APEI, CPER: Enhance memory reporting capability Date: Thu, 17 Oct 2013 07:24:17 -0300 Message-ID: <20131017072417.2f98d2ec@samsung.com> References: <1381935366-11731-1-git-send-email-gong.chen@linux.intel.com> <1381935366-11731-8-git-send-email-gong.chen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w2.samsung.com ([211.189.100.13]:36243 "EHLO usmailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754577Ab3JQKYY (ORCPT ); Thu, 17 Oct 2013 06:24:24 -0400 In-reply-to: <1381935366-11731-8-git-send-email-gong.chen@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Chen, Gong" Cc: tony.luck@intel.com, bp@alien8.de, joe@perches.com, naveen.n.rao@linux.vnet.ibm.com, arozansk@redhat.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Em Wed, 16 Oct 2013 10:56:04 -0400 "Chen, Gong" escreveu: > After H/W error happens under FFM enabled mode, lots of information > are shown but some important parts like DIMM location missed. This > patch is used to show these extra fileds. > > Original-author: Tony Luck > Signed-off-by: Chen, Gong > Acked-by: Naveen N. Rao Reviewed-by: Mauro Carvalho Chehab > --- > drivers/acpi/apei/cper.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c > index 946ef52..b1a8a55 100644 > --- a/drivers/acpi/apei/cper.c > +++ b/drivers/acpi/apei/cper.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -210,6 +211,8 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem) > printk("%s""card: %d\n", pfx, mem->card); > if (mem->validation_bits & CPER_MEM_VALID_MODULE) > printk("%s""module: %d\n", pfx, mem->module); > + if (mem->validation_bits & CPER_MEM_VALID_RANK_NUMBER) > + printk("%s""rank: %d\n", pfx, mem->rank); > if (mem->validation_bits & CPER_MEM_VALID_BANK) > printk("%s""bank: %d\n", pfx, mem->bank); > if (mem->validation_bits & CPER_MEM_VALID_DEVICE) > @@ -232,6 +235,15 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem) > etype < ARRAY_SIZE(cper_mem_err_type_strs) ? > cper_mem_err_type_strs[etype] : "unknown"); > } > + if (mem->validation_bits & CPER_MEM_VALID_MODULE_HANDLE) { > + const char *bank = NULL, *device = NULL; > + dmi_memdev_name(mem->mem_dev_handle, &bank, &device); > + if (bank != NULL && device != NULL) > + printk("%s""DIMM location: %s %s", pfx, bank, device); > + else > + printk("%s""DIMM DMI handle: 0x%.4x", > + pfx, mem->mem_dev_handle); > + } > } > > static const char *cper_pcie_port_type_strs[] = { -- Cheers, Mauro