linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chen Gong <gong.chen@linux.intel.com>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: tony.luck@intel.com, bp@alien8.de, joe@perches.com,
	m.chehab@samsung.com, arozansk@redhat.com,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/9] ACPI, x86: Extended error log driver for x86 platform
Date: Sun, 20 Oct 2013 03:06:15 -0400	[thread overview]
Message-ID: <20131020070615.GA30565@gchen.bj.intel.com> (raw)
In-Reply-To: <52612BA4.2060906@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

[...]

> >diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> >index 22327e6..c67ec61 100644
> >--- a/drivers/acpi/Kconfig
> >+++ b/drivers/acpi/Kconfig
> >@@ -372,4 +372,24 @@ config ACPI_BGRT
> >
> >  source "drivers/acpi/apei/Kconfig"
> >
> >+config ACPI_EXTLOG
> >+	tristate "Extended Error Log support"
> >+	depends on X86_MCE
> 
> I think you also have a dependancy on ACPI_APEI for apei_estatus_print()
> 
Oh, yes it is. Furthermore, it reminds me where is the best place to put
cper.c from I write this patch series. CPER really doesn't dpend on APEI
even ACPI. Maybe lib/ ia an option. I can update this patch and if it is
OK, I can add another separate patch to change this dependency. Make
sense?

> >+	default n
> >+	help
> >+	  Certain usages such as Predictive Failure Analysis (PFA) require
> >+	  more information about the error than what can be described in
> >+	  processor machine check banks. Most server processors log
> >+	  additional information about the error in processor uncore
> >+	  registers. Since the addresses and layout of these registers vary
> >+	  widely from one processor to another, system software cannot
> >+	  readily make use of them. To complicate matters further, some of
> >+	  the additional error information cannot be constructed space
> >+	  between "additional" and "error" without detailed knowledge
> 
> Oops... looks like copy+paste went wrong ;)
> 
Sigh, it looks like I have m a little bit hurry. 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-10-20  7:21 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  8:23 [PATCH v3 0/9] Extended H/W error log driver Chen, Gong
2013-10-18  8:23 ` [PATCH v3 1/9] ACPI, APEI, CPER: Fix status check during error printing Chen, Gong
2013-10-18  8:23 ` [PATCH v3 2/9] ACPI, CPER: Update cper info Chen, Gong
2013-10-18 12:39   ` Naveen N. Rao
2013-10-18  8:23 ` [PATCH v3 3/9] bitops: Introduce a more generic BITMASK macro Chen, Gong
2013-10-18  8:23 ` [PATCH v3 4/9] ACPI, x86: Extended error log driver for x86 platform Chen, Gong
2013-10-18 12:37   ` Naveen N. Rao
2013-10-18 12:53     ` Borislav Petkov
2013-10-18 20:57       ` Luck, Tony
2013-10-18 21:27         ` Borislav Petkov
2013-10-18 22:22           ` Luck, Tony
2013-10-19  9:57             ` Borislav Petkov
2013-10-21 19:03               ` Luck, Tony
2013-10-21 22:39                 ` Tony Luck
2013-10-22  8:37                   ` Borislav Petkov
2013-10-22  9:32                 ` Naveen N. Rao
2013-10-19 11:31     ` Chen Gong
2013-10-20  7:06     ` Chen Gong [this message]
2013-10-20  8:21       ` Borislav Petkov
2013-10-21 16:27         ` Naveen N. Rao
2013-10-20  7:25     ` [PATCH V4 " Chen, Gong
2014-06-27  5:34     ` [PATCH v3 " Xie XiuQi
2014-06-27  9:22       ` Borislav Petkov
2014-06-27 20:43         ` Luck, Tony
2014-06-27 21:14           ` Borislav Petkov
2014-06-27 22:10             ` Luck, Tony
2014-06-27 22:14               ` Borislav Petkov
2014-06-30  6:35               ` Xie XiuQi
2013-10-18  8:23 ` [PATCH v3 5/9] DMI: Parse memory device (type 17) in SMBIOS Chen, Gong
2013-10-18  8:23 ` [PATCH v3 6/9] ACPI, APEI, CPER: Add UEFI 2.4 support for memory error Chen, Gong
2013-10-18  8:23 ` [PATCH v3 7/9] ACPI, APEI, CPER: Enhance memory reporting capability Chen, Gong
2013-10-18  8:23 ` [PATCH v3 8/9] ACPI, APEI, CPER: Cleanup CPER memory error output format Chen, Gong
2013-10-18 12:01   ` Naveen N. Rao
2013-10-19 11:26     ` Chen Gong
2013-10-21 16:22       ` Naveen N. Rao
2013-10-21 17:14         ` Luck, Tony
2013-10-22  8:42           ` Borislav Petkov
2013-10-18  8:23 ` [PATCH v3 9/9] EDAC, GHES: Update ghes error record info Chen, Gong
2013-10-18  9:20 ` [PATCH v3 0/9] Extended H/W error log driver Borislav Petkov
2013-10-18 16:17   ` Tony Luck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131020070615.GA30565@gchen.bj.intel.com \
    --to=gong.chen@linux.intel.com \
    --cc=arozansk@redhat.com \
    --cc=bp@alien8.de \
    --cc=joe@perches.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).