Re: [PATCHv2 1/3] ACPI: Expose struct acpi_device and acpi_bus_get_device() to non-ACPI builds

Jarkko Nikula
2013-11-04T21:16:03Z

On Mon, Nov 04, 2013 at 02:00:45AM +0100, Rafael J. Wysocki wrote:
> On Saturday, November 02, 2013 11:18:31 PM Rafael J. Wysocki wrote:
> > This turns out the cause build problems to happen on some architectures.
> >
> > I guess it's sufficient to simply define a stub struct acpi_device as
> >
> > struct acpi_device {
> > struct device dev;
> > };
> >
> > for !CONFIG_ACPI instead.
>
> Generally, it is a bad idea to #include acpi_bus.h for !CONFIG_ACPI.
>
Ouch, indeed.

> The appended patch works for me, sorry for stealing part of your changelog.
>
No problem. Thanks for fixing this up.

--
Jarkko