Re: [PATCH] ACPI, APEI: Cleanup alignment related codes for APEI

["Chen, Gong" <gong.chen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

On Thu, Nov 07, 2013 at 08:51:32PM +0000, Luck, Tony wrote:
> Date: Thu, 7 Nov 2013 20:51:32 +0000
> From: "Luck, Tony" <tony.luck@intel.com>
> To: "Chen, Gong" <gong.chen@linux.intel.com>, "bp@alien8.de" <bp@alien8.de>
> CC: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
> Subject: RE: [PATCH] ACPI, APEI: Cleanup alignment related codes for APEI
> 
> > We ever used *memcpy* to avoid access alignment issue between
> > firmware and OS. Now we can use a better and standard way
> > to avoid this issue. No functional changes.
> 
> There are some other cleanups in here (changing variable names,
> using structure assignment instead of memcpy).  Commit message
> should describe them all, not just the change that you started out
> to make.
> 
> -Tony
How about this:

We ever used *memcpy* to avoid access alignment issue between
firmware and OS. Now we can use a better and standard way
to avoid this issue. In the meanwhile, simplify some variable names
to avoid the limit of 80 characters per line and use structure
assignment instead of unnecessary memcpy. No functional changes.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]