Re: [PATCH 1/5] net: rfkill: gpio: convert to descriptor-based GPIO interface

Heikki Krogerus
2013-11-22T10:50:16Z

Hi Andy,

On Thu, Nov 21, 2013 at 05:32:28PM +0200, Andy Shevchenko wrote:
> > + /* Make sure at-least one of the GPIO is defined and that
> > + * a name is specified for this instance
> > + */
> > + if ((!rfkill->reset_gpio && !rfkill->shutdown_gpio) || !rfkill->name) {
> > + pr_warn("%s: invalid platform data\n", __func__);
> > + return -EINVAL;
> > + }
> > +
> > + if (pdata && pdata->gpio_runtime_setup) {
> > + ret = pdata->gpio_runtime_setup(pdev);
> > if (ret) {
> > - pr_warn("%s: failed to get shutdown gpio.\n", __func__);
> > + pr_warn("%s: can't set up gpio\n", __func__);
>
> Could you use dev_* family of functions to print messages?

OK, I'll change them. Thanks!

--
heikki