From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [RFC part1 PATCH 3/7] ACPI / processor_core: Rework _PDC related stuff to make it more arch-independent Date: Tue, 3 Dec 2013 17:02:23 +0000 Message-ID: <20131203170223.GA14624@srcf.ucam.org> References: <1386088611-2801-1-git-send-email-hanjun.guo@linaro.org> <1386088611-2801-4-git-send-email-hanjun.guo@linaro.org> <20131203165140.24a05540@alan.etchedpixels.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:34107 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853Ab3LCRCg (ORCPT ); Tue, 3 Dec 2013 12:02:36 -0500 Content-Disposition: inline In-Reply-To: <20131203165140.24a05540@alan.etchedpixels.co.uk> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: One Thousand Gnomes Cc: Hanjun Guo , Mark Rutland , linaro-kernel@lists.linaro.org, Russell King - ARM Linux , Graeme Gregory , patches@linaro.org, Olof Johansson , Catalin Marinas , Linus Walleij , Daniel Lezcano , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Will Deacon , linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org, Rob Herring , Grant Likely , Jon Masters , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org On Tue, Dec 03, 2013 at 04:51:40PM +0000, One Thousand Gnomes wrote: > On Wed, 4 Dec 2013 00:36:47 +0800 > Hanjun Guo wrote: > > > _PDC related stuff in processor_core.c is little bit X86/IA64 dependent, > > rework the code to make it more arch-independent. > > > > The return value of acpi_processor_eval_pdc() should be 'acpi_status' but > > defined as 'int', fix it too. > > Why not just define boot_options_idle_override as well. Then you can > leave the code unchanged. Also more importantly you can have override > values for ARM when it turns out you need those too and the logic will be > the same for both processor families The arguments to _PDC are architecture specific, so there do need to be code changes here. -- Matthew Garrett | mjg59@srcf.ucam.org