From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] aerdrv: Fix severity usage in aer trace event Date: Tue, 10 Dec 2013 01:40:16 +0100 Message-ID: <20131210004016.GG31650@pd.tnic> References: <1386476273-2418-1-git-send-email-rui.y.wang@intel.com> <20131208144312.GC4338@pd.tnic> <20131208150904.GD4338@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Rui Wang , Lance Ortiz , "lance_ortiz@hotmail.com" , jiang.liu@intel.com, Tony Luck , Steven Rostedt , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Chen Gong , Mauro Carvalho Chehab , Rui Wang , Joe Perches List-Id: linux-acpi@vger.kernel.org On Mon, Dec 09, 2013 at 04:41:18PM -0700, Bjorn Helgaas wrote: > I think it's worthwhile to keep all three patches together, and I'd > be happy to merge them via PCI. It looks like Joe had some good > questions, so once you resolve them, I can merge them, or ack them and > you can take them. I think either way will be fine. So actually I'm only really interested in the first patch which clearly fixes a minor issue in the PCIe AER tracepoint and that one I probably should take through the RAS tree as the original patch adding the tracepoint went through it too. Unless you really want to take it - then be my guest! :-) My intention with aerdrv_errprint.c was to cleanup some obvious stuff which sprang at me while looking at the code, *without* *any* change in functionality except the minor and obviously sensible s/aer_tlp_header:/TLP Header:/ replacement. (printk strings are not an API anyway). If you're fine with those patches as they are right now, I can apply them or you can take them or whatever. If not, then so be it. If someone wants to diddle with what could be done better and more readable, then that someone can do this at his own time - I don't really want to waste mine. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --