From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Jeffery To <jeffery.to@gmail.com>,
Wouter Depypere <wouter.depypere@ugent.be>
Subject: Re: [PATCH] ACPI / blacklist: disable Win8 mode for ThinkPad X201 and Latitude E6230
Date: Tue, 10 Dec 2013 17:01:24 +0000 [thread overview]
Message-ID: <20131210170124.GA26978@srcf.ucam.org> (raw)
In-Reply-To: <52A684F1.7070502@intel.com>
On Tue, Dec 10, 2013 at 11:05:21AM +0800, Aaron Lu wrote:
> On 12/10/2013 12:58 AM, Matthew Garrett wrote:
> > On Fri, Dec 06, 2013 at 01:24:02PM +0800, Aaron Lu wrote:
> >> /*
> >> + * The bluetooth functionality is unconditionally enabled
> >> + * after a S3 cycle on Thinkpad X201 under Win8 mode.
> >> + */
> >
> > Can you describe this in a little more detail? Does the thinkpad-acpi
> > rfkill code just not work?
>
> Yes it works, the problem is, even the bluetooth is disabled before
> hibernate, it will be enabled after resume.
Ok. thinkpad_acpi should be ensuring that the state is the same before
and after resume. I don't think it's worth working around this in the
core.
> >> + /*
> >> + * The hardware switch for enable/disable wifi on
> >> + * Dell Latitude E6230 is broken under Win8 mode.
> >> + */
> >
> > Can you define "broken"? Do you see the same behaviour under Windows 8?
>
> As Wouter has put in comment #12:
> "
> I also have trouble with this commit, it disables my hardware switch for
> enable/disable wifi. See [1] for full explanation.
>
> When I add acpi_osi="!Windows 2012" it fixes my issue.
> "
I'd like to be able to dig into this rather than just going straight to
blacklisting.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-12-10 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 5:24 [PATCH] ACPI / blacklist: disable Win8 mode for ThinkPad X201 and Latitude E6230 Aaron Lu
2013-12-06 6:18 ` Aaron Lu
2013-12-09 16:58 ` Matthew Garrett
2013-12-10 3:05 ` Aaron Lu
2013-12-10 17:01 ` Matthew Garrett [this message]
2013-12-11 0:26 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210170124.GA26978@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=aaron.lu@intel.com \
--cc=jeffery.to@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wouter.depypere@ugent.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).