From: Borislav Petkov <bp@alien8.de>
To: tony.luck@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3] ACPI, APEI: Cleanup alignment related codes for APEI
Date: Tue, 17 Dec 2013 16:17:22 +0100 [thread overview]
Message-ID: <20131217151722.GF30592@pd.tnic> (raw)
In-Reply-To: <20131217053451.GB11278@gchen.bj.intel.com>
On Tue, Dec 17, 2013 at 12:34:52AM -0500, Chen, Gong wrote:
> It is a copy from one integer array to another one(from old ID array
> to new bigger ID array), so I can't use a simple evaluation to get
> this goal.
Ok, I see.
Please add this information I spent a couple of days asking you about to
the commit message. Something along the lines of this one:
"erst record id cache is implemented in the memory to increase the
access speed via caching ERST content, so it doesn't matter with
firmware access."
which would explain your last hunk changing the memcpy to a simple
assignment. It is obvious that it is not that trivial information so
documenting it for the future is very important.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-12-17 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 2:07 [PATCH V2] ACPI, APEI: Cleanup alignment related codes for APEI Chen, Gong
2013-11-14 1:49 ` Chen, Gong
2013-11-14 12:29 ` Borislav Petkov
2013-11-15 5:38 ` Chen, Gong
2013-11-15 5:45 ` [PATCH v3] " Chen, Gong
2013-11-16 11:48 ` Borislav Petkov
2013-12-14 13:41 ` Chen, Gong
2013-12-14 16:45 ` Borislav Petkov
2013-12-16 14:19 ` Borislav Petkov
2013-12-16 14:39 ` Chen, Gong
2013-12-16 17:55 ` Borislav Petkov
2013-12-17 5:34 ` Chen, Gong
2013-12-17 15:17 ` Borislav Petkov [this message]
2013-12-18 6:30 ` [PATCH v4] " Chen, Gong
2013-12-18 21:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217151722.GF30592@pd.tnic \
--to=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).