From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Fleming Subject: Re: [RFC PATCH 06/14] rtc-efi: register rtc-efi device when EFI enabled Date: Thu, 19 Dec 2013 14:09:33 +0000 Message-ID: <20131219140918.GF3145@console-pimps.org> References: <1387439515-8926-1-git-send-email-jlee@suse.com> <1387439515-8926-7-git-send-email-jlee@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from arkanian.console-pimps.org ([212.110.184.194]:54451 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336Ab3LSOJj (ORCPT ); Thu, 19 Dec 2013 09:09:39 -0500 Content-Disposition: inline In-Reply-To: <1387439515-8926-7-git-send-email-jlee@suse.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Lee, Chun-Yi" Cc: "Rafael J. Wysocki" , Alessandro Zummo , "H. Peter Anvin" , Matthew Garrett , Elliott@hp.com, samer.el-haj-mahmoud@hp.com, Oliver Neukum , werner@suse.com, trenn@suse.de, JBeulich@suse.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, x86@kernel.org, "linux-efi@vger.kernel.org" , linux-acpi@vger.kernel.org, "Lee, Chun-Yi" , Matt Fleming , Thomas Gleixner , Ingo Molnar On Thu, 19 Dec, at 03:51:47PM, Lee, Chun-Yi wrote: > UEFI time services, GetTime(), SetTime(), GetWakeupTime(), SetWakeupTime() are also > supported by other non-IA64 architecutre with UEFI BIOS, e.g. x86. > > This patch changed RTC_DRV_EFI configuration to depend on EFI but not just IA64. It > checks efi_enabled flag and efi-rtc driver should enabled. > > Cc: Matt Fleming > Cc: H. Peter Anvin > Cc: Matthew Garrett > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Jan Beulich > Signed-off-by: Lee, Chun-Yi > --- > arch/x86/platform/efi/efi.c | 17 +++++++++++++++++ > drivers/rtc/Kconfig | 2 +- > 2 files changed, 18 insertions(+), 1 deletions(-) This patch needs to be justified. Enabling the EFI runtime *Time functions just because they're available isn't good enough. We need to know why this patch improves things, what use case does it solve? The general attitude has been that we want to invoke the runtime services less, not more, due to the huge variety of runtime implementation bugs. -- Matt Fleming, Intel Open Source Technology Center