* [PATCH] ACPI / video: Use native backlight control interface by default
@ 2013-12-05 2:03 AceLan Kao
2013-12-05 2:32 ` Matthew Garrett
0 siblings, 1 reply; 4+ messages in thread
From: AceLan Kao @ 2013-12-05 2:03 UTC (permalink / raw)
To: linux-acpi, Matthew Garrett, Zhang Rui, Len Brown,
Rafael J. Wysocki
The native/vendor backlight control interface is hardly fail to control the
brightness, and we had encountered many backlight issues result from the broken
ACPI backlight interface, so I think we should promote the native backlight
control interface and use it by default.
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
drivers/acpi/video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 995e91b..b3032f8 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644);
* For Windows 8 systems: if set ture and the GPU driver has
* registered a backlight interface, skip registering ACPI video's.
*/
-static bool use_native_backlight = false;
+static bool use_native_backlight = true;
module_param(use_native_backlight, bool, 0644);
static int register_count;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / video: Use native backlight control interface by default
2013-12-05 2:03 [PATCH] ACPI / video: Use native backlight control interface by default AceLan Kao
@ 2013-12-05 2:32 ` Matthew Garrett
2013-12-05 7:50 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Matthew Garrett @ 2013-12-05 2:32 UTC (permalink / raw)
To: AceLan Kao
Cc: linux-acpi, Zhang Rui, Len Brown, Rafael J. Wysocki, intel-gfx,
daniel.vetter
We had problems with the Intel backlight driver the last time we tried
this, so let's push this through their tree for testing first? Cc:ed
intel-gfx and Daniel Vetter.
On Thu, Dec 05, 2013 at 10:03:57AM +0800, AceLan Kao wrote:
> The native/vendor backlight control interface is hardly fail to control the
> brightness, and we had encountered many backlight issues result from the broken
> ACPI backlight interface, so I think we should promote the native backlight
> control interface and use it by default.
>
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
> drivers/acpi/video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index 995e91b..b3032f8 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644);
> * For Windows 8 systems: if set ture and the GPU driver has
> * registered a backlight interface, skip registering ACPI video's.
> */
> -static bool use_native_backlight = false;
> +static bool use_native_backlight = true;
> module_param(use_native_backlight, bool, 0644);
>
> static int register_count;
> --
> 1.8.3.2
>
>
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / video: Use native backlight control interface by default
2013-12-05 2:32 ` Matthew Garrett
@ 2013-12-05 7:50 ` Daniel Vetter
2013-12-20 6:32 ` Aaron Lu
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2013-12-05 7:50 UTC (permalink / raw)
To: Matthew Garrett
Cc: intel-gfx, Rafael J. Wysocki, linux-acpi, AceLan Kao, Zhang Rui,
Len Brown
On Thu, Dec 5, 2013 at 3:32 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> We had problems with the Intel backlight driver the last time we tried
> this, so let's push this through their tree for testing first? Cc:ed
> intel-gfx and Daniel Vetter.
Makes sense imo. Or if I just get a branch with just those patches (it
can rebase, I don't really care) I could pull it into our
drm-intel-nightly integration tree, which is what everyone is testing
anyway.
-Daniel
>
>
> On Thu, Dec 05, 2013 at 10:03:57AM +0800, AceLan Kao wrote:
>> The native/vendor backlight control interface is hardly fail to control the
>> brightness, and we had encountered many backlight issues result from the broken
>> ACPI backlight interface, so I think we should promote the native backlight
>> control interface and use it by default.
>>
>> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
>> ---
>> drivers/acpi/video.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>> index 995e91b..b3032f8 100644
>> --- a/drivers/acpi/video.c
>> +++ b/drivers/acpi/video.c
>> @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644);
>> * For Windows 8 systems: if set ture and the GPU driver has
>> * registered a backlight interface, skip registering ACPI video's.
>> */
>> -static bool use_native_backlight = false;
>> +static bool use_native_backlight = true;
>> module_param(use_native_backlight, bool, 0644);
>>
>> static int register_count;
>> --
>> 1.8.3.2
>>
>>
> --
> Matthew Garrett | mjg59@srcf.ucam.org
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / video: Use native backlight control interface by default
2013-12-05 7:50 ` Daniel Vetter
@ 2013-12-20 6:32 ` Aaron Lu
0 siblings, 0 replies; 4+ messages in thread
From: Aaron Lu @ 2013-12-20 6:32 UTC (permalink / raw)
To: Daniel Vetter
Cc: Matthew Garrett, AceLan Kao, linux-acpi, Zhang Rui, Len Brown,
Rafael J. Wysocki, intel-gfx
On Thu, Dec 05, 2013 at 08:50:21AM +0100, Daniel Vetter wrote:
> On Thu, Dec 5, 2013 at 3:32 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > We had problems with the Intel backlight driver the last time we tried
> > this, so let's push this through their tree for testing first? Cc:ed
> > intel-gfx and Daniel Vetter.
>
> Makes sense imo. Or if I just get a branch with just those patches (it
> can rebase, I don't really care) I could pull it into our
> drm-intel-nightly integration tree, which is what everyone is testing
> anyway.
Only this patch is needed, all other patches have been in Linus' tree
since v3.13-rc1.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-20 6:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-05 2:03 [PATCH] ACPI / video: Use native backlight control interface by default AceLan Kao
2013-12-05 2:32 ` Matthew Garrett
2013-12-05 7:50 ` Daniel Vetter
2013-12-20 6:32 ` Aaron Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).