From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h Date: Sun, 5 Jan 2014 19:28:49 -0800 Message-ID: <20140106032849.GA20605@leaf> References: <37de640470c91e2e54ab68a158e19dde3938f18a.1387271324.git.rashika.kheria@gmail.com> <1528697.GH1GrQaKgp@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from relay4-d.mail.gandi.net ([217.70.183.196]:53607 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbaAFD27 convert rfc822-to-8bit (ORCPT ); Sun, 5 Jan 2014 22:28:59 -0500 Content-Disposition: inline In-Reply-To: <1528697.GH1GrQaKgp@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Rashika Kheria , linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote: > On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote: > > Include header file internal.h in debugfs.c and change the return > > value's type in header file internal.h. > >=20 > > This eliminates the following warning in debugfs.c: > > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for =E2= =80=98acpi_debugfs_init=E2=80=99 [-Wmissing-prototypes] > >=20 > > Signed-off-by: Rashika Kheria > > Reviewed-by: Josh Triplett > > --- > > drivers/acpi/debugfs.c | 3 +++ > > drivers/acpi/internal.h | 2 +- > > 2 files changed, 4 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c > > index b55d6a2..96bcaf7 100644 > > --- a/drivers/acpi/debugfs.c > > +++ b/drivers/acpi/debugfs.c > > @@ -6,6 +6,7 @@ > > #include > > #include > > #include > > +#include "internal.h" > > =20 > > #define _COMPONENT ACPI_SYSTEM_COMPONENT > > ACPI_MODULE_NAME("debugfs"); > > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs"); > > struct dentry *acpi_debugfs_dir; > > EXPORT_SYMBOL_GPL(acpi_debugfs_dir); > > =20 > > +#ifdef CONFIG_DEBUG_FS > > void __init acpi_debugfs_init(void) > > { > > acpi_debugfs_dir =3D debugfs_create_dir("acpi", NULL); > > } > > +#endif >=20 > What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS= unset? >=20 > That surely would make sense?=20 It exports the symbol acpi_debugfs_dir, which is used unconditionally. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html