Re: [PATCH] x86, acpi memory hotplug, add parameter to disable memory hotplug

Vivek Goyal
2014-01-14T14:36:18Z

On Mon, Jan 13, 2014 at 06:41:29PM -0700, Toshi Kani wrote:
> On Tue, 2014-01-14 at 10:11 +0900, Yasuaki Ishimatsu wrote:
> :
> > >> I think we need a knob manually enable mem-hotplug when specify memmap. But
> > >> it is another story.
> > >>
> > >> Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > >
> > > As mentioned, self-NAK. I have seen a system that I needed to specify
> > > memmap=exactmap & had hotplug memory. I will only keep the acpi_no_memhotplug
> > > option in the next version of the patch.
> >
> >
> > Your following first patch is simply and makes sense.
> >
> > http://marc.info/?l=linux-acpi&m=138922019607796&w=2
> >
>
> In this option, it also requires changing kexec-tools to specify the new
> option for kdump. It won't be simpler.

I am thinking that instead of modifying kexec-tools, it can be made
part of the documentation so that user is expected to pass this parameter.

In fedora, we can modify /etc/sysconfig/kdump and add the parameter by
default so that user's don't have to worry about passing it.

Thanks
Vivek