From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v4] ACPI / video: Add systems that should favour native backlight interface Date: Tue, 18 Feb 2014 17:46:40 +0200 Message-ID: <20140218154640.GT5018@intel.com> References: <5302F58C.1080001@intel.com> <20140218103442.GS5018@intel.com> <1903167.TtlOFgMB6X@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1903167.TtlOFgMB6X@vostro.rjw.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: "Rafael J. Wysocki" Cc: Aaron Lu , Theodore Tso , Kevin Smith , ACPI Devel Mailing List , Takashi Iwai , Peter Weber , "intel-gfx@lists.freedesktop.org" , Vladimir Sherenkov , Matthew Garrett , "linux-kernel@vger.kernel.org" , Thomas Christensen , Lennart Poettering , sov.info@mail.ru, "platform-driver-x86@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote: > On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: > > At Tue, 18 Feb 2014 12:34:42 +0200, > > Mika Westerberg wrote: > > > > > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > > > + { > > > > + .callback = video_set_use_native_backlight, > > > > + .ident = "HP EliteBook 2013 models", > > > > + .matches = { > > > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook "), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, " G1"), > > > > + }, > > > > + }, > > > > > > I see my device is listed here but the above doesn't really use native > > > backlight because it is still in acpi_osi blacklist. Tried this and I can > > > see both acpi_video0 and intel_backlight listed under /sys/class/backlight. > > > Was this the intention? > > > > The acpi_osi blacklist commit (2d4054d84224) has to be reverted, as I > > mentioned earlier. But the revert can be done individually after > > merging this patch. Rafael, could you care? > > Done. Please check the result in linux-pm.git/linux-next. With your revert and this patch from Aaron, backlight on my HP EliteBook Revolve G1 works fine, thanks! Tested-by: Mika Westerberg