public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* next-20140312 - build error in drivers/acpi/sleep.c
@ 2014-03-13 18:48 Valdis Kletnieks
  2014-03-13 21:23 ` Rafael J. Wysocki
  0 siblings, 1 reply; 6+ messages in thread
From: Valdis Kletnieks @ 2014-03-13 18:48 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-kernel, linux-acpi

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

Seen in the most recent linux-next with a CONFIG_SUSPEND=n .config:

  CC      drivers/acpi/sleep.o
drivers/acpi/sleep.c: In function 'acpi_sleep_init':
drivers/acpi/sleep.c:808:2: error: implicit declaration of function 'acpi_sleep_state_supported' [-Werror=implicit-function-declaration]
  if (acpi_sleep_state_supported(ACPI_STATE_S5)) {
  ^
cc1: some warnings being treated as errors
make[2]: *** [drivers/acpi/sleep.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2

Function is defined inside a #ifdef CONFIG_SUSPEND, but used outside of
one in acpi_sleep_init().

git blame points at commit eaa54ccbc:

commit eaa54ccbcf81de987e6978ad457cc9e425b7a8db
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Tue Mar 11 14:08:58 2014 +0100

    ACPI / sleep: Add extra checks for HW Reduced ACPI mode sleep states

    If the HW Reduced ACPI mode bit is set in the FADT, ACPICA uses
    the optional sleep control and sleep status registers for making
    the system enter sleep states (including S5), so it is not possible
    to use system sleep states or power it off using ACPI if the HW
    Reduced ACPI mode bit is set and those registers are not available.

    For this reason, add a new function, acpi_sleep_state_supported(),
    checking if the HW Reduced ACPI mode bit is set and whether or not
    system sleep states are usable in that case in addition to checking
    the return value of acpi_get_sleep_type_data() and make the ACPI
    sleep setup routines use that function to check the availability of
    system sleep states.


[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-16  0:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-13 18:48 next-20140312 - build error in drivers/acpi/sleep.c Valdis Kletnieks
2014-03-13 21:23 ` Rafael J. Wysocki
2014-03-13 22:53   ` David Rientjes
2014-03-14  0:08   ` Fengguang Wu
2014-03-14 20:56   ` Valdis.Kletnieks
2014-03-16  0:30     ` David Rientjes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox