linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Lippers-Hollmann" <s.L-H@gmx.de>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 3.14-rc: /proc/acpi/battery gone?
Date: Sun, 16 Mar 2014 03:57:48 +0000	[thread overview]
Message-ID: <201403160357.53858.s.L-H@gmx.de> (raw)
In-Reply-To: <532471EC.1070107@intel.com>

Hi

On Saturday 15 March 2014, Lan Tianyu wrote:
> On 03/14/2014 10:17 PM, Stefan Lippers-Hollmann wrote:
> > Hi
> >
> > On Saturday 15 March 2014, Rafael J. Wysocki wrote:
> >> On Friday, March 14, 2014 06:14:12 PM Ilia Mirkin wrote:
> >>> On Fri, Mar 14, 2014 at 6:11 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >>>> On Fri 2014-03-14 17:29:41, Ilia Mirkin wrote:
> >>>>> On Fri, Mar 14, 2014 at 5:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
[...]
> Hi Stefan:
> 	I just glance wmbattery code. I find the code in the acpi.c is already 
> using the new sysfs battery interfaces, right?

By default, wmbattery appears to default to using upower as abstraction
level, instead of querying sysfs itself directly.

http://git.kitenet.net/?p=wmbattery.git;a=blob;f=autoconf/makeinfo.in;hb=HEAD

which sets USE_UPOWER=1 by default.

If USE_UPOWER=0 is set explicitly for the build, it reverts back to 
direct sysfs parsing - and yes, it does appear to adhere to the current
sysfs API properly.

The last remains, and the ability to parse procfs (which hasn't been 
default for quite some time already, in favour of using hal as 
abstraction layer) has finally been removed in

http://git.kitenet.net/?p=wmbattery.git;a=commitdiff;h=833eb63a5ce4f2fb712a201b1db4f2db1700fddb

The switch from procfs parsing to hal (by default at least) in turn 
happened with

http://git.kitenet.net/?p=wmbattery.git;a=commitdiff;h=63c3d1a0b11e8ade1a5612bb5baa3d92e153bbbe

in 2008 (before Debian squeeze/ oldstable). I have not investigated if 
hal then read from procfs or sysfs, but wmbattery at least didn't read
from procfs itself, unless explicitly told to do so (USE_HAL=0) during 
the build since mid 2008.

The current version of wmbattery however will never try to access 
/proc/acpi, the current version no longer knows of its existence.

[Again, I'm not familiar with wmbattery myself and have never run it]

Regards
	Stefan Lippers-Hollmann

  parent reply	other threads:[~2014-03-16  3:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 21:14 3.14-rc: /proc/acpi/battery gone? Pavel Machek
2014-03-14 21:20 ` Pavel Machek
2014-03-14 21:29 ` Ilia Mirkin
2014-03-14 21:45   ` Richard Weinberger
2014-03-15 15:10     ` Lan Tianyu
2014-03-14 22:11   ` Pavel Machek
2014-03-14 22:14     ` Ilia Mirkin
2014-03-15  1:46       ` Rafael J. Wysocki
2014-03-15  2:17         ` Stefan Lippers-Hollmann
2014-03-15 15:29           ` Lan Tianyu
2014-03-15 16:05             ` Pavel Machek
2014-03-15 17:27               ` Lan Tianyu
2014-03-16 11:12                 ` Pavel Machek
2014-03-16  3:57             ` Stefan Lippers-Hollmann [this message]
2014-03-17 17:28               ` Ilia Mirkin
2014-04-20 13:09                 ` Pavel Machek
2014-04-21 11:29                   ` Lan Tianyu
2014-03-15 14:08         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201403160357.53858.s.L-H@gmx.de \
    --to=s.l-h@gmx.de \
    --cc=imirkin@alum.mit.edu \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).