Re: [PATCH v3 3/5] x86: fix list corruption on CPU hotplug

[Igor Mammedov <imammedo@redhat.com>]

On Mon, 14 Apr 2014 12:04:57 +0200
Ingo Molnar <mingo@kernel.org> wrote:

> 
> * Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > On Mon, 14 Apr 2014 11:19:54 +0200
> > Ingo Molnar <mingo@kernel.org> wrote:
> > 
> > > 
> > > * Igor Mammedov <imammedo@redhat.com> wrote:
> > > 
> > > > currently if AP wake up is failed, master CPU marks AP as not present
> > > > in do_boot_cpu() by calling set_cpu_present(cpu, false).
> > > > That leads to following list corruption on the next physical CPU
> > > > hotplug:
> > > 
> > > Shouldn't this fix precede the main change to the smp bootup logic?
> > > 
> > > Can this bug trigger with current upstream kernels?
> > That's not impossible, tests showed that with current kernel there will
> > be other problems due wild AP running around.
> > 
> > I'll reorder patch anyway.
> 
> So, could you please first make sure that with only the fixes applied 
> there's no problems left?
Sure, I'll retest reordered series.

> 
> Only then should we apply the patch that adds/tweaks the timeout/etc.
> 
> Thanks,
> 
> 	Ingo


-- 
Regards,
  Igor