From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
devel@acpica.org, kernel-hardening@lists.openwall.com,
Kees Cook <keescook@chromium.org>, Dave Jones <davej@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Robert Moore <robert.moore@intel.com>,
Lv Zheng <lv.zheng@intel.com>
Subject: Re: [patch] lib: check for strcpy() overflows to fixed length buffers
Date: Tue, 6 May 2014 15:41:57 +0300 [thread overview]
Message-ID: <20140506124157.GT4963@mwanda> (raw)
In-Reply-To: <20140430201529.GX4963@mwanda>
On Wed, Apr 30, 2014 at 11:15:29PM +0300, Dan Carpenter wrote:
> > > diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h
> > > index e863dd5..5e0fc2b 100644
> > > --- a/include/acpi/platform/acenv.h
> > > +++ b/include/acpi/platform/acenv.h
> >
> > This is an ACPICA header and changes to it need to be submitted to the ACPICA
> > maintainers (as per MAINTAINERS). We only get ACPICA changes from the
> > upstream project (except for really special situations).
>
> Ok. I should have added Robert and Lv to the CC list. My guess is
> that the (void) is needed to avoid compile warnings but it's needed for
> us to avoid compile breakage with this change.
>
> Anyway, I'll wait for a couple days and resend that bit broken out.
>
In the end, I won't need to modify the ACPICA headers if I use an
expression statement ({ ... }) instead of a do { } while (0) statement.
Thanks, though. :)
regards,
dan carpenter
next prev parent reply other threads:[~2014-05-06 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 15:08 [patch] lib: check for strcpy() overflows to fixed length buffers Dan Carpenter
2014-04-30 15:33 ` Kees Cook
2014-04-30 16:19 ` Dan Carpenter
2014-04-30 16:44 ` Kees Cook
2014-04-30 19:49 ` Rafael J. Wysocki
2014-04-30 20:15 ` Dan Carpenter
2014-05-05 0:19 ` Zheng, Lv
2014-05-06 12:41 ` Dan Carpenter [this message]
2014-05-01 4:06 ` Solar Designer
2014-05-01 7:45 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506124157.GT4963@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=devel@acpica.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).