From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] lib: check for strcpy() overflows to fixed length buffers Date: Tue, 6 May 2014 15:41:57 +0300 Message-ID: <20140506124157.GT4963@mwanda> References: <20140430150844.GA10621@mwanda> <1507574.Y0KFKOdI6F@vostro.rjw.lan> <20140430201529.GX4963@mwanda> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: <20140430201529.GX4963@mwanda> To: "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, kernel-hardening@lists.openwall.com, Kees Cook , Dave Jones , Andrew Morton , Robert Moore , Lv Zheng List-Id: linux-acpi@vger.kernel.org On Wed, Apr 30, 2014 at 11:15:29PM +0300, Dan Carpenter wrote: > > > diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h > > > index e863dd5..5e0fc2b 100644 > > > --- a/include/acpi/platform/acenv.h > > > +++ b/include/acpi/platform/acenv.h > > > > This is an ACPICA header and changes to it need to be submitted to the ACPICA > > maintainers (as per MAINTAINERS). We only get ACPICA changes from the > > upstream project (except for really special situations). > > Ok. I should have added Robert and Lv to the CC list. My guess is > that the (void) is needed to avoid compile warnings but it's needed for > us to avoid compile breakage with this change. > > Anyway, I'll wait for a couple days and resend that bit broken out. > In the end, I won't need to modify the ACPICA headers if I use an expression statement ({ ... }) instead of a do { } while (0) statement. Thanks, though. :) regards, dan carpenter