From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 4/7] acpi, apei, ghes: Factor out NMI error notification context. Date: Tue, 13 May 2014 21:41:25 +0200 Message-ID: <20140513194125.GD8760@pd.tnic> References: <1397056476-9183-1-git-send-email-tomasz.nowicki@linaro.org> <1397056476-9183-5-git-send-email-tomasz.nowicki@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail.skyhub.de ([78.46.96.112]:57962 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752316AbaEMTlf (ORCPT ); Tue, 13 May 2014 15:41:35 -0400 Content-Disposition: inline In-Reply-To: <1397056476-9183-5-git-send-email-tomasz.nowicki@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tomasz Nowicki Cc: rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, bp@suse.de, m.chehab@samsung.com, linux-edac@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org On Wed, Apr 09, 2014 at 05:14:32PM +0200, Tomasz Nowicki wrote: > Use CONFIG_ACPI_APEI_NMI to isolate NMI error notification path. NMI related > data and functions are grouped so they can be wrapped inside one > > Signed-off-by: Tomasz Nowicki > --- > drivers/acpi/apei/ghes.c | 54 +++++++++++++++++++++++++--------------------- > 1 file changed, 30 insertions(+), 24 deletions(-) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index ca8387e..7a0d66e 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -53,7 +53,9 @@ > #include > #endif > #include > +#ifdef CONFIG_ACPI_APEI_NMI > #include > +#endif This, again, can be avoided with adding arch-specific versions and empty default stubs. > #include "apei-internal.h" ... -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --