linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jin Yao <yao.jin@linux.intel.com>,
	Li Aubrey <aubrey.li@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/4] ACPI / LPSS: custom power domain for LPSS
Date: Mon, 26 May 2014 16:42:34 +0300	[thread overview]
Message-ID: <20140526134234.GA12107@xps8300> (raw)
In-Reply-To: <11413734.64aCNVobNb@vostro.rjw.lan>

On Mon, May 26, 2014 at 03:03:27PM +0200, Rafael J. Wysocki wrote:
> On Friday, May 23, 2014 04:15:09 PM Heikki Krogerus wrote:
> > A power domain where we save the context of the additional
> > LPSS registers. We need to do this or all LPSS devices are
> > left in reset state when resuming from D3 on some Baytrails.
> > The devices with the fractional clock divider also have
> > zeros for N and M values after resuming unless they are
> > reset.
> > 
> > Li Aubrey found the root cause for the issue. The idea of
> > using power domain for LPSS came from Mika Westerberg.
> > 
> > Reported-by: Jin Yao <yao.jin@linux.intel.com>
> > Suggested-by: Li Aubrey <aubrey.li@linux.intel.com>
> > Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> 
> Queued up for 3.16, but I needed to rebase it to take some other changes
> into account.  Can you please have a look and the bleeding-edge branch in
> my tree and see if everything looks good in there?

I checked the bleeding-edge and it looks good to me. Thanks for taking
care of the issue with "%lx".

About the sparse warning from the clk-fractional-divider.c. Since
there is no real issue, let's follow the style in the other clock
types and ignore the warning. So let's keep that patch as it is. OK?



-- 
heikki

  reply	other threads:[~2014-05-26 13:42 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15 13:40 [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100 Heikki Krogerus
2014-05-15 13:40 ` [PATCHv2 1/4] ACPI / PM: Export rest of the subsys functions Heikki Krogerus
2014-05-15 13:40 ` [PATCHv2 2/4] ACPI / LPSS: custom power domain for LPSS Heikki Krogerus
2014-05-20 21:33   ` Rafael J. Wysocki
2014-05-21 10:05     ` Heikki Krogerus
2014-05-21 11:01       ` Rafael J. Wysocki
2014-05-21 10:52         ` Heikki Krogerus
2014-05-21 23:28           ` Rafael J. Wysocki
2014-05-23 12:30             ` Heikki Krogerus
2014-05-23 13:10               ` Rafael J. Wysocki
2014-05-23 13:02                 ` Heikki Krogerus
2014-05-23 13:15                   ` [PATCHv3 " Heikki Krogerus
2014-05-26 13:03                     ` Rafael J. Wysocki
2014-05-26 13:42                       ` Heikki Krogerus [this message]
2014-05-26 21:30                         ` Rafael J. Wysocki
2014-05-15 13:40 ` [PATCHv2 3/4] clk: new basic clk type for fractional divider Heikki Krogerus
2014-05-15 16:53   ` Mike Turquette
2014-05-16 22:38     ` Rafael J. Wysocki
     [not found]       ` <20140516230905.9521.88763@quantum>
2014-05-17  0:15         ` Rafael J. Wysocki
     [not found]           ` <20140517013403.9521.86191@quantum>
2014-05-19  0:15             ` Rafael J. Wysocki
2014-05-15 13:40 ` [PATCHv2 4/4] ACPI / LPSS: support for fractional divider clock Heikki Krogerus
2014-05-19 11:42   ` [PATCHv3 " Heikki Krogerus
2014-05-15 14:35 ` [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100 Li, Aubrey
2014-05-15 14:53   ` Andy Shevchenko
2014-05-15 15:59     ` Li, Aubrey
2014-05-15 16:11       ` Mika Westerberg
2014-05-15 23:29         ` Li, Aubrey
2014-05-16  7:04           ` Andy Shevchenko
2014-05-16 13:37             ` Li, Aubrey
2014-05-16 14:45               ` Andy Shevchenko
2014-05-20 11:17                 ` Li, Aubrey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140526134234.GA12107@xps8300 \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).