From: Borislav Petkov <bp@alien8.de>
To: "Chen, Gong" <gong.chen@linux.intel.com>
Cc: tony.luck@intel.com, m.chehab@samsung.com, rostedt@goodmis.org,
linux-acpi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7 v3] trace, AER: Move trace into unified interface
Date: Wed, 11 Jun 2014 21:00:35 +0200 [thread overview]
Message-ID: <20140611190035.GC14923@pd.tnic> (raw)
In-Reply-To: <1402475691-30045-3-git-send-email-gong.chen@linux.intel.com>
On Wed, Jun 11, 2014 at 04:34:46AM -0400, Chen, Gong wrote:
> AER uses a separate trace interface by now. To make it
> consistent, move it into unified RAS trace interface.
>
> v3 -> v2: change dependency rule of RAS_TRACE.
> v2 -> v1: remove unnecessary dependency in drivers/ras/Kconfig.
>
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> ---
> drivers/pci/pcie/aer/Kconfig | 1 +
> drivers/pci/pcie/aer/aerdrv_errprint.c | 4 +-
> include/ras/ras_event.h | 64 ++++++++++++++++++++++++++++
> include/trace/events/ras.h | 77 ----------------------------------
> 4 files changed, 66 insertions(+), 80 deletions(-)
> delete mode 100644 include/trace/events/ras.h
>
> diff --git a/drivers/pci/pcie/aer/Kconfig b/drivers/pci/pcie/aer/Kconfig
> index 50e94e0..c611384 100644
> --- a/drivers/pci/pcie/aer/Kconfig
> +++ b/drivers/pci/pcie/aer/Kconfig
> @@ -5,6 +5,7 @@
> config PCIEAER
> boolean "Root Port Advanced Error Reporting support"
> depends on PCIEPORTBUS
> + select RAS_TRACE
> default y
> help
> This enables PCI Express Root Port Advanced Error Reporting
With this hunk changed to
Index: b/drivers/pci/pcie/aer/Kconfig
===================================================================
--- a/drivers/pci/pcie/aer/Kconfig 2014-06-11 17:33:57.298417802 +0200
+++ b/drivers/pci/pcie/aer/Kconfig 2014-06-11 17:34:16.302417487 +0200
@@ -5,6 +5,7 @@
config PCIEAER
boolean "Root Port Advanced Error Reporting support"
depends on PCIEPORTBUS
+ select RAS
default y
help
This enables PCI Express Root Port Advanced Error Reporting
--
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-06-11 19:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 8:34 New eMCA trace event interface V4 Chen, Gong
2014-06-11 8:34 ` [PATCH 1/7 v5] trace, RAS: Add basic RAS trace event Chen, Gong
2014-06-11 18:59 ` Borislav Petkov
2014-06-11 8:34 ` [PATCH 2/7 v3] trace, AER: Move trace into unified interface Chen, Gong
2014-06-11 19:00 ` Borislav Petkov [this message]
2014-06-11 8:34 ` [PATCH 3/7 v5] CPER: Adjust code flow of some functions Chen, Gong
2014-06-11 8:34 ` [PATCH 4/7 v2] RAS, debugfs: Add debugfs interface for RAS subsystem Chen, Gong
2014-06-11 19:01 ` Borislav Petkov
2014-06-11 8:34 ` [PATCH 5/7 v7] trace, RAS: Add eMCA trace event interface Chen, Gong
2014-06-11 19:02 ` Borislav Petkov
2014-06-12 2:42 ` Chen, Gong
2014-06-11 8:34 ` [PATCH 6/7 v4] trace, eMCA: Add a knob to adjust where to save event log Chen, Gong
2014-06-11 8:34 ` [PATCH 7/7] RAS, extlog: Adjust init flow Chen, Gong
2014-06-11 21:33 ` New eMCA trace event interface V4 Luck, Tony
2014-06-12 6:11 ` [PATCH 5/7 REVISION] trace, RAS: Add eMCA trace event interface Chen, Gong
2014-06-12 13:28 ` Steven Rostedt
2014-06-13 2:19 ` Chen, Gong
2014-06-13 3:01 ` Steven Rostedt
2014-06-13 3:08 ` Steven Rostedt
2014-06-13 7:09 ` Chen, Gong
2014-06-17 2:09 ` Chen, Gong
2014-06-17 3:37 ` Steven Rostedt
2014-06-17 12:59 ` Steven Rostedt
2014-06-18 2:33 ` eMCA trace interface update Chen, Gong
2014-06-18 2:33 ` [PATCH 5/7 REVISION v2] trace, RAS: Add eMCA trace event interface Chen, Gong
2014-06-20 2:06 ` Chen, Gong
2014-06-20 23:01 ` Tony Luck
2014-06-21 0:56 ` Steven Rostedt
2014-06-22 16:48 ` Borislav Petkov
2014-06-23 23:51 ` Luck, Tony
2014-06-24 10:20 ` Borislav Petkov
2014-06-24 17:38 ` Luck, Tony
-- strict thread matches above, loose matches on Subject: below --
2014-05-15 8:30 New " Chen, Gong
2014-05-15 8:30 ` [PATCH 2/7 v3] trace, AER: Move trace into unified interface Chen, Gong
2014-05-21 10:19 ` Borislav Petkov
2014-05-22 0:03 ` Chen, Gong
2014-05-22 10:41 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611190035.GC14923@pd.tnic \
--to=bp@alien8.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).