Re: [PATCH v3 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

Robert Richter
2014-06-13T13:54:02Z

On 13.06.14 13:02:56, Tomasz Nowicki wrote:
> This commit abstracts MCE calls and provides weak corresponding default
> implementation for those architectures which do not need arch specific
> actions. Each platform willing to do additional architectural actions
> should provides desired function definition. It allows us to avoid wrap
> code into #ifdef in generic code and prevent new platform from introducing
> dummy stub function too.
>
> Initially, there are two APEI arch-specific calls:
> - apei_arch_enable_cmcff()
> - apei_arch_report_mem_error()
> Both interact with MCE driver for X86 architecture.
>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> ---
> arch/x86/kernel/acpi/Makefile | 1 +
> arch/x86/kernel/acpi/apei.c | 56 +++++++++++++++++++++++++++++++++++++++++
> drivers/acpi/apei/apei-base.c | 13 ++++++++++
> drivers/acpi/apei/ghes.c | 6 ++---
> drivers/acpi/apei/hest.c | 29 +--------------------
> include/acpi/apei.h | 3 +++
> 6 files changed, 76 insertions(+), 32 deletions(-)
> create mode 100644 arch/x86/kernel/acpi/apei.c

Looks fine to me.

-Robert