Re: [PATCH v3 4/5] apei, ghes, nmi: Factor out NMI arch-specific calls.

Robert Richter
2014-06-13T13:29:35Z

On 13.06.14 13:02:59, Tomasz Nowicki wrote:
> Similar to MCE related patch, all NMI architectural calls are abstracted.
> Also, we are providing corresponding X86 functions' content.

We don't need to abstract nmi calls for archs that don't support
nmis. Just disable the code with #ifdefs depending on
ARCH_HAS_ACPI_APEI_NMI. Most changes in this patch, esp. all __weak
functions are obsolete then.

The remainings of this patch could probably merged with earlier
patches.

-Robert

>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> ---
> arch/x86/kernel/acpi/apei.c | 25 +++++++++++++++++++++++++
> drivers/acpi/apei/apei-base.c | 19 +++++++++++++++++++
> drivers/acpi/apei/ghes.c | 14 ++++++--------
> include/acpi/apei.h | 7 +++++++
> 4 files changed, 57 insertions(+), 8 deletions(-)