From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Patch V3 00/16] Enable support of IOAPIC hotplug on x86 platforms Date: Wed, 16 Jul 2014 09:33:05 -0400 Message-ID: <20140716133305.GG19585@laptop.dumpdata.com> References: <1403685648-10103-1-git-send-email-jiang.liu@linux.intel.com> <20140714172642.GA12920@laptop.dumpdata.com> <20140714194133.GA22857@laptop.dumpdata.com> <53C54876.5090606@linux.intel.com> <20140715161035.GA8097@laptop.dumpdata.com> <53C5EB19.7060104@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:32191 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758996AbaGPNjB (ORCPT ); Wed, 16 Jul 2014 09:39:01 -0400 Content-Disposition: inline In-Reply-To: <53C5EB19.7060104@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiang Liu Cc: Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , Andrew Morton , Tony Luck , Joerg Roedel , Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org On Wed, Jul 16, 2014 at 11:01:45AM +0800, Jiang Liu wrote: > Hi Konrad, Hey Jiang, > We have found the root cause with your great support. If BIOS > assigns an IRQ number for a PCI device, acpi_pci_irq_enable() fails to I would think that is a common scenario? > assign IOAPIC IRQ then due to the check: > if (dev->irq > 0) > return 0; I should really look in the code to figure this out - but I think your patch will have a detail analysis that will make tglrx happy, so will just wait till then :-) > For a quick workaround, just comment out above check. But we > need some time to figure out a clean fixup for it. We will send out new > version once it gets resolved. Excellent. Once you do, please do give me the git tree so I can slurp it in my testing > Thanks for your great help again. Of course! Thank you for your quick turn-around. > Regards! > Gerry > On 2014/7/16 0:10, Konrad Rzeszutek Wilk wrote: > > already assigned IRQ