public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Julian Wollrath <jwollrath@web.de>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org
Subject: Re: [Regression]: Changing brightness does not work with v3.16-rc4
Date: Wed, 16 Jul 2014 13:36:29 +0200	[thread overview]
Message-ID: <20140716133629.4b6d19c4@saldaea> (raw)
In-Reply-To: <53C5E548.8000905@intel.com>

Am Wed, 16 Jul 2014 10:36:56 +0800
schrieb Aaron Lu <aaron.lu@intel.com>:

> On 07/15/2014 02:56 AM, Julian Wollrath wrote:
> > Am Mon, 14 Jul 2014 21:10:47 +0200
> > schrieb "Rafael J. Wysocki" <rjw@rjwysocki.net>:
> > 
> >> On Monday, July 14, 2014 09:02:34 PM Rafael J. Wysocki wrote:
> >>> On Monday, July 14, 2014 08:34:22 PM Julian Wollrath wrote:
> >>>> Am Mon, 14 Jul 2014 20:21:19 +0200
> >>>> schrieb "Rafael J. Wysocki" <rjw@rjwysocki.net>:
> >>>>
> >>>>> On Saturday, July 12, 2014 06:24:52 PM Julian Wollrath wrote:
> >>>>>> Hi,
> >>>>>>
> >>>>>>> changing the brightness on my Thinkpad X230 with Intel
> >>>>>>> HD4000 graphics, stopped working after commit 886129a8eebe
> >>>>>>> (ACPI / video: change acpi-video brightness_switch_enabled
> >>>>>>> default to 0). Changing it back to 1, fixes the problem, if
> >>>>>>> "acpi_osi=!Windows 2012" is also set. Before that commit
> >>>>>>> just setting "acpi_osi=!Windows 2012" was enough to get
> >>>>>>> changing the brightness working.
> >>>>>>
> >>>>>> small correction: It setting "acpi_osi=!Windows 2012" does
> >>>>>> only help when using a kernel with commit 886129a8eebe as
> >>>>>> HEAD, with v3.16-rc4 setting
> >>>>>> video.brightness_switch_enabled=1 and acpi_osi=!Windows 2012
> >>>>>> or just one of them, does not make changing the brightness
> >>>>>> work again.
> >>>>>
> >>>>> And reverting commit 751109aad583 (ACPI / video: Change the
> >>>>> default for video.use_native_backlight to 1) make that last
> >>>>> problem go away, right?
> >>>>>
> >>>>> We are going to rever commit 886129a8eebe for other reasons, so
> >>>>> can you please revert it from 3.16-rc5 on your system and
> >>>>> report back?
> >>>> Yes, with both 751109aad583 and 886129a8eebe reverted, changing
> >>>> the brightness works again.
> >>>
> >>> What if you revert 886129a8eebe alone?
> >>
> >> I mean, what exactly do you need to pass to the kernel command line
> >> in that case to make brightness switching work?
> > I need to pass
> >   acpi_osi="!Windows 2012" video.brightness_switch_enabled=1
> > video.use_native_backlight=-1
> > 
> > If I leave one of these parameters out, the brightness switch stops
> > working.
> 
> If you only pass the following 2 cmdline options:
> acpi_osi="!Windows 2012" video.brightness_switch_enabled=1
> Will there be the /sys/class/backlight/acpi_videoX file?

Yes, and interestingly with v3.16-rc5 the brightness switching works
with just these two options.

Cheers,
Julian

  reply	other threads:[~2014-07-16 11:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 16:06 [Regression]: Changing brightness does not work with v3.16-rc4 Julian Wollrath
2014-07-12 16:24 ` Julian Wollrath
2014-07-14 18:21   ` Rafael J. Wysocki
2014-07-14 18:34     ` Julian Wollrath
2014-07-14 19:02       ` Rafael J. Wysocki
2014-07-14 19:10         ` Rafael J. Wysocki
2014-07-14 18:56           ` Julian Wollrath
2014-07-14 19:17             ` Rafael J. Wysocki
2014-07-15  6:06               ` Aaron Lu
2014-07-15 12:27                 ` Rafael J. Wysocki
2014-07-15 14:00                   ` Aaron Lu
2014-07-15 14:05                   ` Hans de Goede
2014-07-15 14:45                     ` Aaron Lu
2014-07-16  0:43                       ` Rafael J. Wysocki
2014-07-16  6:29                         ` Hans de Goede
2014-07-16  7:19                           ` Aaron Lu
2014-07-16  8:13                             ` Hans de Goede
2014-07-16  8:30                               ` Aaron Lu
2014-07-16  8:35                               ` Hans de Goede
2014-07-16 11:50                                 ` Julian Wollrath
2014-07-16 11:52                                   ` Hans de Goede
2014-07-15 21:38                 ` Julian Wollrath
2014-07-16  2:36             ` Aaron Lu
2014-07-16 11:36               ` Julian Wollrath [this message]
2014-07-14  2:06 ` Aaron Lu
2014-07-14 12:42   ` Julian Wollrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140716133629.4b6d19c4@saldaea \
    --to=jwollrath@web.de \
    --cc=aaron.lu@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox