From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 0/3] ACPI / PM: Make ACPI-based PCI wakeup work for the "freeze" sleep state Date: Wed, 23 Jul 2014 13:38:40 +0200 Message-ID: <20140723113840.GJ20603@laptop.programming.kicks-ass.net> References: <1907495.agrCMfRsQN@vostro.rjw.lan> <3271848.fNJ1rk2xTa@vostro.rjw.lan> <20140723072850.GO3935@laptop> <1938033.aGLPbNTjeQ@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:46351 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbaGWLio (ORCPT ); Wed, 23 Jul 2014 07:38:44 -0400 Content-Disposition: inline In-Reply-To: <1938033.aGLPbNTjeQ@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Linux Kernel Mailing List , Linux PM list , Linux PCI , Zhang Rui On Wed, Jul 23, 2014 at 01:43:59PM +0200, Rafael J. Wysocki wrote: > On Wednesday, July 23, 2014 09:28:50 AM Peter Zijlstra wrote: > > On Wed, Jul 23, 2014 at 12:26:20AM +0200, Rafael J. Wysocki wrote: > > > All of that indicates that the machine in question has WoL based on native PCIe > > > PME signaling. In that case it doesn't wake up from the "freeze" state, because > > > some code is missing. > > > > Didn't wake, but it did show: > > > > 0000:00:01.0:pcie01 1 1 0 0 0 0 0 99207 0 > > LNXPWRBN:00 1 1 0 0 0 0 0 99191 0 > > > > So at least something's moving, although its not quite working yet. > > That may be because I forgot about one piece, sorry about that. > This patch: > > https://patchwork.kernel.org/patch/4526561/ > > (which I think is in tip already) is needed to make enable_irq_wake() > work with the "freeze" state. > > Can you please apply this in addition and retest? I appear to have that hunk already (I'm running -tip based kernels). (also, patchwork blows chunks :/)