From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Lambert Subject: [PATCH 3/3] PCI hotplug: remove assignement from if conditions Date: Mon, 4 Aug 2014 21:01:53 +0200 Message-ID: <20140804190153.GA4257@greed> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-pci-owner@vger.kernel.org To: "Rafael J. Wysocki" , Len Brown , Bjorn Helgaas , Scott Murray , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org The following Coccinelle semantic patch was used to find and correct cases of assignements in if conditions: @ifassign@ expression var, expr; statement S; @@ - if(!(var = expr)) S + var = expr; + if(!var) S Signed-off-by: Quentin Lambert --- drivers/pci/hotplug/acpi_pcihp.c | 3 ++- drivers/pci/hotplug/cpcihp_zt5550.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c index a94d850..2cac548 100644 --- a/drivers/pci/hotplug/acpi_pcihp.c +++ b/drivers/pci/hotplug/acpi_pcihp.c @@ -433,7 +433,8 @@ int acpi_pci_check_ejectable(struct pci_bus *pbus, acpi_handle handle) { acpi_handle bridge_handle, parent_handle; - if (!(bridge_handle = acpi_pci_get_bridge_handle(pbus))) + bridge_handle = acpi_pci_get_bridge_handle(pbus); + if (!bridge_handle) return 0; if ((ACPI_FAILURE(acpi_get_parent(handle, &parent_handle)))) return 0; diff --git a/drivers/pci/hotplug/cpcihp_zt5550.c b/drivers/pci/hotplug/cpcihp_zt5550.c index 2b222fc..4d0cf3f 100644 --- a/drivers/pci/hotplug/cpcihp_zt5550.c +++ b/drivers/pci/hotplug/cpcihp_zt5550.c @@ -237,8 +237,9 @@ static int zt5550_hc_init_one (struct pci_dev *pdev, const struct pci_device_id dbg("registered controller"); /* Look for first device matching cPCI bus's bridge vendor and device IDs */ - if (!(bus0_dev = pci_get_device(PCI_VENDOR_ID_DEC, - PCI_DEVICE_ID_DEC_21154, NULL))) { + bus0_dev = pci_get_device(PCI_VENDOR_ID_DEC, + PCI_DEVICE_ID_DEC_21154, NULL); + if (!bus0_dev) { status = -ENODEV; goto init_register_error; } -- 1.9.1